Skip to content

opentracing, jaeger, xnio, debezium, log4j2, assertj, junit-jupiter minor version updates #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

opentracing, jaeger, xnio, debezium, log4j2, assertj, junit-jupiter minor version updates #1561

merged 1 commit into from
Mar 19, 2019

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Mar 18, 2019 •
edited
Loading

opentracing, jaeger, xnio, debezium, log4j2, assertj, junit-jupiter minor version updates

I tried locally both mvn clean install and mvn clean install -Dnative, no issues hit.

@rsvoboda
Copy link
Member Author

rsvoboda commented Mar 18, 2019 •
edited
Loading

Weird, I haven't seen any failure locally.
Running io.quarkus.example.test.RestClientITCase again to be sure: mvn -pl integration-tests/main clean integration-test -Dnative -Dit.test=RestClientITCase -Dtest=NONE -DfailIfNoTests=false

Update: tests from RestClientITCase passed, using 1.0.0-rc13

@dmlloyd
Copy link
Member

dmlloyd commented Mar 18, 2019

Don't bother updating jboss-modules, it's only a compilation stub at this point. In fact, let's see if we can remove it completely now that JBoss LogManager is out of tree.

@rsvoboda
Copy link
Member Author

I will update the PR tmr, still struggling to reproduce failures from CI.

Installed F29 into VirtualBox, running main module of integration TS with -Dnative and have pass.

Any tips are welcome.

@rsvoboda
Copy link
Member Author

So the tests which are failing were merged 5 hours ago - 0311eb8
So that's why I didn't see the failures

@vorburger vorburger mentioned this pull request Mar 18, 2019
Closed
@rsvoboda
Copy link
Member Author

I see the failures on master too :(

@rsvoboda rsvoboda changed the title opentracing, jaeger, xnio, debezium, jboss-modules, log4j2, assertj, junit-jupiter minor version updates opentracing, jaeger, xnio, debezium, log4j2, assertj, junit-jupiter minor version updates Mar 19, 2019
@rsvoboda
Copy link
Member Author

Test issue was fixed, reverting the reverts and dropping jboss-modules update

@Sanne
Copy link
Member

Sanne commented Mar 19, 2019

great, thanks! Testing one last time locally ...

@Sanne Sanne self-assigned this Mar 19, 2019
@Sanne Sanne merged commit f43ea90 into quarkusio:master Mar 19, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 19, 2019
@rsvoboda rsvoboda deleted the minorVersionUpdates branch March 4, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sanne Sanne Sanne approved these changes

Assignees

@Sanne Sanne

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rsvoboda @dmlloyd @Sanne @gsmet