Update opentracing doc to describe using application.properties as alternative to env vars #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alternative to env vars
gsmet
requested changes
Mar 17, 2019
There was a problem hiding this comment.
@objectiser looks good to me, thanks.
I added a minor comment about the usage of ./mvw. Could you fix that and I'll merge? Thanks!
| [source, text] | ||
| ---- | ||
| ./mvnw compile quarkus:dev -Djvm.args="-DJAEGER_SERVICE_NAME=myservice -DJAEGER_SAMPLER_TYPE=const -DJAEGER_SAMPLER_PARAM=1 -DJAEGER_ENDPOINT=http://localhost:14268/api/traces" | ||
| mvn compile quarkus:dev |
There was a problem hiding this comment.
We decided to go with the Maven wrapper approach as we had a few reports with people not using the right version of Maven. Could you change it back to ./mvnw?
| [source, text] | ||
| ---- | ||
| mvn compile quarkus:dev -Djvm.args="-DJAEGER_SERVICE_NAME=myservice -DJAEGER_SAMPLER_TYPE=const -DJAEGER_SAMPLER_PARAM=1 -DJAEGER_ENDPOINT=http://localhost:14268/api/traces" | ||
| ---- |
|
@gsmet updated. Thanks. |
gsmet
approved these changes
Mar 17, 2019
|
Merged, thanks! |
cescoffier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies quarkusio/quarkus-quickstarts#107.