Improve the dependencies between gradle tasks #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `assemble` is the standard gradle lifecycle task used to build the artifact (i.e. the jar in the case of a classical Java project). So `assemble` now depends on `quarkusBuild`, which produces the runner jar - `classes` is the standard lifecycle task which produces the classes (and copies the resources). Since that's what `quarkusBuild` and `quarkusDev` need as input (as far as I understand), they now depend on the `classes` task, instead of depending on the `build` task - The `build` task is the standard gradle lifecycle task to run a complete build, including the production of the jar artifact, the compilation and execution of the tests, the static code analysis checks such as PMD, CheckStyle, etc. It's the top-level task, and nothing should normally depend on the `build` task. The `quarkusDev` and `quarkusBuild` tasks which depended on `build` now don't depend on it anymore, since all they should need is the output of the `classes` task. So now `./gradlew assemble` produces the runner jar as expected by a gradle user. So does `./gradlew build` of course, since `build` depends on `assemble`. `./gradlew quarkusDev` and `./gradlew quarkusBuild` won't compile and run all the tests and static code analysis checks, since that's not what these tasks are supposed to do. fix quarkusio#1442
stalep
reviewed
Mar 15, 2019
|
@stalep I had a look at the gradle-tooling guide, and I didn't notice anything that needed to be changed, but maybe I missed something, or maybe you're thinking about something else. |
|
ah, ofc that was already updated, forget my stupid comment then :) |
stalep
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assembleis the standard gradle lifecycle task used to build the artifact (i.e. the jar in the case of a classical Java project). Soassemblenow depends onquarkusBuild, which produces the runner jarclassesis the standard lifecycle task which produces the classes (and copies the resources). Since that's whatquarkusBuildandquarkusDevneed as input (as far as I understand), they now depend on theclassestask, instead of depending on thebuildtaskbuildtask is the standard gradle lifecycle task to run a complete build, including the production of the jar artifact, the compilation and execution of the tests, the static code analysis checks such as PMD, CheckStyle, etc. It's the top-level task, and nothing should normally depend on thebuildtask. ThequarkusDevandquarkusBuildtasks which depended onbuildnow don't depend on it anymore, since all they should need is the output of theclassestask.So now
./gradlew assembleproduces the runner jar as expected by a gradle user. So does./gradlew buildof course, sincebuilddepends onassemble../gradlew quarkusDevand./gradlew quarkusBuildwon't compile and run all the tests and static code analysis checks, since that's not what these tasks are supposed to do.fix #1442