Skip to content

Improve ArC integration #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Improve ArC integration #1485

merged 1 commit into from
Mar 15, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 14, 2019

  • merge FullArchiveIndexBuildItem into BeanArchiveBuildItem
  • fix the default annotation transformer - use special stereotype
    instead of Dependent

This a follow-up of #1383

@mkouba
Improve ArC integration
eb71f3e 
- merge FullArchiveIndexBuildItem into BeanArchiveBuildItem
- fix the default annotation transformer - use special stereotype
instead of Dependent
@mkouba mkouba requested review from gsmet and stuartwdouglas March 14, 2019 12:36
@mkouba mkouba mentioned this pull request Mar 14, 2019
Merged
@mkouba
Copy link
Contributor Author

mkouba commented Mar 14, 2019

Connect to repository.jboss.org:80 timed out again :-(. I'll try to re-run once again.

@mkouba
Copy link
Contributor Author

mkouba commented Mar 14, 2019 

[ERROR] Failed to execute goal on project quarkus-jdbc-mssql-runtime: Could not resolve dependencies for project io.quarkus:quarkus-jdbc-mssql-runtime:jar:999-SNAPSHOT: Failed to collect dependencies at com.microsoft.sqlserver:mssql-jdbc:jar:7.2.1.jre8: Failed to read artifact descriptor for com.microsoft.sqlserver:mssql-jdbc:jar:7.2.1.jre8: Could not transfer artifact com.microsoft.sqlserver:mssql-jdbc:pom:7.2.1.jre8 from/to jboss-public-repository-group (http://repository.jboss.org/nexus/content/groups/developer/): Connect to repository.jboss.org:80 timed out -> [Help 1]

Hm, timeout again. Let's try again for the last time. @gsmet @stuartwdouglas is this a known issue?

@gsmet
Copy link
Member

gsmet commented Mar 14, 2019

@mkouba yes :/. I created a topic on Zulip so that we can discuss this. We need to find a solution as it's really annoying. I will open an internal issue to see if it's an issue with our Nexus or a connection problem.

gsmet
gsmet approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I launched a new CI run.

@mkouba mkouba mentioned this pull request Mar 15, 2019
Merged
@mkouba
Copy link
Contributor Author

mkouba commented Mar 15, 2019

Yet another timeout. I'm going to run the full build locally and if it passes I'll merge this.

@mkouba mkouba merged commit c9e9d0e into quarkusio:master Mar 15, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

+1 more reviewer

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mkouba @gsmet @stuartwdouglas