Add MicroProfile Fault Tolerance guide #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Mar 7, 2019
|
|
||
| == Adding Resiliency: Timeouts | ||
|
|
||
| So what else have we've got in MicroProfile Fault Tolerance? Let's look into timeouts. |
| ``` | ||
|
|
||
| You can see that every time an invocation fails, it's immediately followed by another invocation, until one succeeds. | ||
| Since we allowed 4 retries, it would require 5 invocations to fail in row, in order for the user to be actually exposed |
| Note that the timeout was configured to 250 ms, and a random artificial delay between 0 to 500 ms was introduced | ||
| into the `CoffeeResource#recommendations()` method. | ||
|
|
||
| In your browser, go to `http://localhost:8080/coffee/2/recommendations` and hit refresh couple of times. |
|
|
||
| In your browser, go to `http://localhost:8080/coffee/2/recommendations` and hit refresh couple of times. | ||
|
|
||
| You should see some requests timeout with `org.eclipse.microprofile.faulttolerance.exceptions.TimeoutException`. |
There was a problem hiding this comment.
I think it would be time out the verb here?
| In your browser, go to `http://localhost:8080/coffee/2/recommendations` and hit refresh couple of times. | ||
|
|
||
| You should see some requests timeout with `org.eclipse.microprofile.faulttolerance.exceptions.TimeoutException`. | ||
| Requests that do not timeout should show two recommended coffee samples in JSON. |
|
|
||
| `mvn quarkus:add-extension -Dextensions="smallrye-fault-tolerance"` | ||
|
|
||
| * or simply adding following Maven dependency: |
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-smallrye-fault-tolerance-deployment</artifactId> | ||
| <version>${quarkus.version}</version> |
There was a problem hiding this comment.
2 things: you need to drop the -deployment suffix now (it's a last minute change we made to Quarkus) and you can drop the version, people should use the BOM.
| -DprojectArtifactId=microprofile-fault-tolerance \ | ||
| -DclassName="org.acme.faulttolerance.CoffeeResource" \ | ||
| -Dpath="/coffee" \ | ||
| -Dextensions="smallrye-fault-tolerance, resteasy-jsonb, arc" |
| -Dextensions="smallrye-fault-tolerance, resteasy-jsonb, arc" | ||
| ---- | ||
|
|
||
| This command generates a Maven structure importing the extensions for RESTEasy/JAX-RS, Dependency Injection (Arc) |
| ---- | ||
|
|
||
| This command generates a Maven structure importing the extensions for RESTEasy/JAX-RS, Dependency Injection (Arc) | ||
| and Smallrye Fault Tolerance, which is an implementation of MicroProfile Fault Tolerance spec that Quarkus uses. |
There was a problem hiding this comment.
of the MicroProfile Fault Tolerance spec
TomasHofman
force-pushed
the
fault-tolerance-guide
branch
from
0280bc5 to
d7a6d89
Compare
|
@gsmet thanks so much for corrections, I agree with everything. Oy, the articles... The quickstart project PR is here: quarkusio/quarkus-quickstarts#79 |
gsmet
approved these changes
Mar 9, 2019
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microprofile Fault Tolerance guide.
Related quickstart PR: quarkusio/quarkus-quickstarts#79