Remove -deployment suffix from artifacts #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
artifact-rename
branch
from
c195320 to
953def3
Compare
cescoffier
changed the title
maxandersen
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
* feat: add jbang jdk install <version> <path> - Ability to link pre-installed JDK directory to JBang - Documentation update Fixes quarkusio#1248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the -deployment suffix from artifacts, which will remove the need for users to change them once the Toronto model is implemented.
I am not sure if we will want to do this, but I am opening this so it can be tested and will be ready if we want to do it.