Skip to content

Ignore static and final fields in config objects #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Ignore static and final fields in config objects #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/deployment/src/main/java/io/quarkus/deployment/configuration/ConfigDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.lang.reflect.AnnotatedElement;
import java.lang.reflect.Field;
import java.lang.reflect.Member;
import java.lang.reflect.Modifier;
import java.lang.reflect.Parameter;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
Expand Down Expand Up @@ -172,6 +173,15 @@ private GroupConfigType processConfigGroup(final String containingName, final Co
GroupConfigType gct = new GroupConfigType(containingName, container, consumeSegment, configGroupClass, accessorFinder);
final Field[] fields = configGroupClass.getDeclaredFields();
for (Field field : fields) {
final int mods = field.getModifiers();
if (Modifier.isStatic(mods)) {
// ignore static fields
continue;
}
if (Modifier.isFinal(mods)) {
// ignore final fields
continue;
}
final ConfigItem configItemAnnotation = field.getAnnotation(ConfigItem.class);
final String name = configItemAnnotation == null ? hyphenate(field.getName()) : configItemAnnotation.name();
String subKey;
Expand Down