Skip to content

Removing obsolete test #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Removing obsolete test #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions devtools/maven/src/test/java/io/quarkus/maven/it/DevMojoIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import org.apache.commons.io.FileUtils;
import org.apache.maven.shared.invoker.MavenInvocationException;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import com.google.common.collect.ImmutableMap;
Expand Down Expand Up @@ -134,47 +133,6 @@ public void testThatTheApplicationIsReloadedOnNewResource() throws MavenInvocati
.atMost(1, TimeUnit.MINUTES).until(() -> getHttpResponse("/app/foo").contains("bar"));
}

@Test
@Disabled("Issue https://github.com/jbossas/protean-shamrock/issues/245")
public void testThatTheApplicationIsReloadedOnNewServlet() throws MavenInvocationException, IOException {
testDir = initProject("projects/classic", "projects/project-classic-run-new-servlet");
runAndCheck();

File source = new File(testDir, "src/main/java/org/acme/MySimpleServlet.java");
String myNewServlet = "package org.acme;\n" +
"\n" +
"import java.io.IOException;\n" +
"\n" +
"import javax.servlet.annotation.WebServlet;\n" +
"import javax.servlet.http.HttpServlet;\n" +
"import javax.servlet.http.HttpServletRequest;\n" +
"import javax.servlet.http.HttpServletResponse;\n" +
"\n" +
"@WebServlet(name=\"MyServlet\", urlPatterns=\"/my\")\n" +
"public class MySimpleServlet extends HttpServlet {\n" +
" \n" +
" @Override\n" +
" protected void doGet(HttpServletRequest request, \n" +
" HttpServletResponse response) throws IOException {\n" +
" response.setContentType(\"text/plain\");\n" +
" response.getWriter().println(\"hello from servlet\");\n" +
" }\n" +
"}";
FileUtils.write(source, myNewServlet, Charset.forName("UTF-8"));

await()
.pollDelay(1, TimeUnit.SECONDS)
.atMost(1, TimeUnit.MINUTES).until(() -> getHttpResponse("/my").contains("hello from servlet"));

// delete servlet
source.delete();

await()
.pollDelay(1, TimeUnit.SECONDS)
.atMost(1, TimeUnit.MINUTES).until(() -> getHttpResponse("/my", 404));

}

private void runAndCheck() throws FileNotFoundException, MavenInvocationException {
assertThat(testDir).isDirectory();
running = new RunningInvoker(testDir, false);
Expand Down