Skip to content

Conversation

stalep
Copy link
Member

@stalep stalep commented Mar 4, 2019

No description provided.

@stalep
Copy link
Member Author

stalep commented Mar 4, 2019

i decided to split out the maven tooling into a separate document. users interested in maven are not interested in gradle and vice versa. - but if others disagree im fine with trying to weave it all into one doc.

Copy link
Member

@emmanuelbernard emmanuelbernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I think I preferred a single tooling doc but it would have made for a verbose solution.
The main problem is the missing CLI adoc file.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stalep I added additional comments.

Please ping me when you applied the changes and added the CLI guide. I will review it again.

@n1hility
Copy link
Collaborator

n1hility commented Mar 5, 2019

So based on our discussions last week and just now (including with @emmanuelbernard ), we have a bunch of usability work with tool that we are out of time to do (e.g. how do you get the tool, does it install maven since you can't use the project without maven, etc). We can skip the CLI section for now. and merge without it.

gsmet
gsmet previously requested changes Mar 5, 2019
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stalep even if we don't include the CLI guide tomorrow, I added a few comments. I think the most important one is the s/MICRONAUT/QUARKUS/ one.

It would be nice if you could amend the commit so that it doesn't appear in the history.

@stalep
Copy link
Member Author

stalep commented Mar 5, 2019

i rebased it all into one commit, thanks again for the reviews @gsmet !

@stalep stalep requested a review from gsmet March 5, 2019 22:48
@starksm64 starksm64 dismissed stale reviews from emmanuelbernard and gsmet March 6, 2019 06:49

Changes look to be applied

@starksm64 starksm64 merged commit 6e73d8a into quarkusio:master Mar 6, 2019
@gsmet gsmet added this to the 0.11.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants