Minor doc change proposals for getting started guides #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a incorrect reference to the executable. Clarify the notion of executable tailored for the local OS.
|
PR for #1171 |
cescoffier
approved these changes
Mar 4, 2019
gsmet
approved these changes
Mar 4, 2019
| Because the Docker container may not use the same _executable_ format as the one produced by default, we must instruct the Maven build to produce an | ||
| executable from inside a Docker container: | ||
|
|
||
| By default, the native image is tailored for your operating system (Windows, macOS etc). |
There was a problem hiding this comment.
Should it be Linux, macOS? Considering you can't build native images for Windows right now.
There was a problem hiding this comment.
Isn't it in beta? On the readme it's written "Building images on Windows is still experimental."
There was a problem hiding this comment.
I don't know: they don't provide binaries here: https://www.graalvm.org/downloads/ .
I just think that we should talk about Linux first anyway.
But it's a detail, feel free to merge it as is.
There was a problem hiding this comment.
year I was future proofing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.