-
Notifications
You must be signed in to change notification settings - Fork 3k
First complete draft of the using JWT RBAC guide #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a couple of typos and then there is this question of the configuration properties.
I suppose the mp.jwt
ones are directly accessed by the SmallRye JWT library? Not sure if it will be easy to make them Quarkus ones and pass the property along.
|quarkus.jwt.enabled|true|Determine if the jwt extension is enabled. Enabled by default if you include the smallrye-jwt dependency, so this would be used to disable it. | ||
|quarkus.jwt.realm-name|Quarkus-JWT|Name to use for security realm. | ||
|quarkus.jwt.auth-mechanism|MP-JWT|Name to use for authentication mechanism | ||
|mp.jwt.verify.publickey|none|The `mp.jwt.verify.publickey` config property allows the Public Key text itself to be supplied as a string. The Public Key will be parsed from the supplied string in the order defined in section <<Supported Public Key Formats>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance, these properties could be made consistent with the others? The idea was really to expose a consistent set of Quarkus config properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really as these are the values defined by the MP-JWT specification. We can have duplicates, but then we are not really supporting the MicroProfile specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I suspected. For the record, we already have non-quarkus-prefixed properties with the REST client: we define the service URLs using the MP syntax.
@emmanuelbernard thoughts?
Apparently the latest pull with rebase was not done or not done correctly? Is there a way to fix the commits associated with this PR? |
Another rebase with force push looks to have cleaned this up |
@starksm64 you missed some of my comments (they might be hidden by GitHub as there are too many of them). The remaining ones are all here: https://github.com/jbossas/protean-shamrock/pull/1162/files . |
Ok, the 8f61938 commit should have addressed everything but the mp.* property names. |
OK, let's merge it, we can discuss the general issue of properties defined in the MP specs later. |
No description provided.