Skip to content

Hibernate 2LC separation into independent project #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Hibernate 2LC separation into independent project #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c5309f
Switch the new Hibernate 2LC implementation to quarkus-local-cache as…
Sanne Mar 1, 2019
8e8d59a
Delete independent-projects/infinispan-hibernate-cache-quarkus
Sanne Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extensions/hibernate-orm/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@
<artifactId>svm</artifactId>
</dependency>
<dependency>
<groupId>org.infinispan.quarkus</groupId>
<artifactId>infinispan-hibernate-cache-quarkus</artifactId>
<version>${project.version}</version>
<groupId>org.hibernate</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably too late but, IIRC, we decided to not push any new artifacts at the root of org.hibernate. We moved all our artifacts to specific subdirectories.

On Zulip, you initially suggested org.hibernate.quarkus.

BTW, wondering how it will be synchronized to Maven Central? I'm not sure the root of org.hibernate is automatically synchronized to Central or if we have to specify specific directories.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, your two questions are related.

I preferred org.hibernate.quarkus but I won't get a new groupId approved on time. So piggi-backing on org.hibernate for now, as anything in there published on JBoss Nexus gets synched to Maven Central - and doesn't need signatures either.

We'll move it to a better group when the fate of this project gets clearer - there's also the possibility that it gets absorbed in ORM6.

<artifactId>quarkus-local-cache</artifactId>
<version>0.1.0</version>
</dependency>
<!-- Technically the quarkus-caffeine-runtime belongs as a dependency to the Quarkus Caching layer,
but since this is currently shaped as a non-quarkus external project I'd rather not have it depend on
Expand Down
242 changes: 0 additions & 242 deletions independent-projects/infinispan-hibernate-cache-quarkus/pom.xml
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions ...uarkus/src/main/java/org/infinispan/quarkus/hibernate/cache/AbstractDomainDataAccess.java
View file
Open in desktop

This file was deleted.

Loading