Disable building the main IT native image test by default #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was against it until now but, with the recent additions made to the main IT tests (I think the Kafka one was the one making it fail for me), it becomes very hard to get the main IT to build the native image on a typical laptop with other applications running.
We will have more people testing the build soon and they will most probably have errors due to that. Sometimes the error is clear and GraalVM complains about being unable to allocate memory but sometimes you end up with an error with a code 137 and no explanation.
With this patch, you have two possibilities to run the main native image test:
-Dnativewill run it along with all the other native tests;-Pnative-image-it-mainwill only test native image for the main IT.