Inject all dependencies in bom #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was indented with 3 spaces.
Otherwise it's impossible to make updates to the BOM that affects the Maven plugin as the Maven plugin tests gets the BOM from the remote repository, thus getting an outdated version.
This will avoid dependency hell. Typically, the REST HTTP demo just stopped working due to javax.json being 1.1.2 there whereas it's 1.1.4 in Quarkus. See #1134 We might have to add more in the future and tune this.
stuartwdouglas
approved these changes
Mar 2, 2019
maxandersen
added a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
…uarkusio#1141) * fix: Allow --deps to specify multiple dependencies (quarkusio#815) * Apply suggestion Co-authored-by: Max Rydahl Andersen <[email protected]> * Apply suggestion Co-authored-by: Max Rydahl Andersen <[email protected]> Co-authored-by: Max Rydahl Andersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a big one. The idea is to definitely fix issues such as #1134 .
Stuart tried at some point to inject the RESTEasy BOM in our BOM but it failed because the other dependencies were missing.
This PR injects all the versions in the BOM.
Note that we might have to add more dependencies to the BOM if we find some issues but at least the issue will be fixed once and for all.
Obviously, this is a structural change but, considering the old way was breaking existing applications, I think this work is a solid foundation and we can tweak it by adding additional dependencies to the BOM if we detect issues.
BTW the approach is very similar to what Spring Boot does with its dependencies pom.