Skip to content

Conversation

starksm64
Copy link
Contributor

Move attributes out from html output into common section
Add attributes for the various forms of the github urls; clone, archive, source file, source directory
Add attributes for both quarkus and quickstarts
Replace all hard-coded urls with attribute references

Add attributes for the various forms of the github urls; clone, archive, source file, source directory
Add attributes for both quarkus and quickstarts
Replace all hard-coded urls with attribute references
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good except for a search/replace error in the native guide.

The output of the log is also not consistent with what we have now. We should probably go through the quickstarts and update it as David and Stuart fixed the log output recently.

@starksm64
Copy link
Contributor Author

I have fixed the copy and paste errors.

@gsmet gsmet merged commit 67b6865 into quarkusio:master Mar 1, 2019
@gsmet gsmet added this to the 0.11.0 milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants