Document mocking an authorization server with Mockito #10396
Conversation
|
|
||
| [source,java] | ||
| ---- | ||
| private static WireMockServer wireMockServer = new WireMockServer(); |
There was a problem hiding this comment.
I am pretty sure that we want to do something like
instead of this per pest configurationThere was a problem hiding this comment.
Bot approache are good for different reason.
If we prefere TestResource I'm OK to switch to it inside our integration test and update the guide.
There was a problem hiding this comment.
Not really, when you use %test.quarkus.oauth2.introspection-url=http://localhost:8080/introspect it applies to all tests, so best make sure that you have a Wiremock server up for all tests
There was a problem hiding this comment.
This is a good point indead ;)
loicmathieu
force-pushed
the
doc/oauth2-mock-authorization-server
branch
from
a3cca08 to
6956c3c
Compare
|
@geoand I switch to using a test resource instead of starting Wiremock directly inside the test. I must admit it is way elegant (I love the fact you can override runtime properties, learn a new trick ;) ). I'll open a quickstart PR to include this inside the quickstart with a test. |
|
Excellent, thanks a lot @loicmathieu! I'll take a quick look later on, but I'll let @sberyozkin have the final say. |
|
And the PR that update the quickstart is here: quarkusio/quarkus-quickstarts#609 |
loicmathieu
force-pushed
the
doc/oauth2-mock-authorization-server
branch
from
6956c3c to
3765f3b
Compare
There was a problem hiding this comment.
This is just super cool, thanks @geoand for doing the real review :-)
@loicmathieu - thanks
|
I'll follow Loic's lead and do something similar for the quarkus-oidc |
|
@loicmathieu you can now merge this on your own, right? |
Yes, this will be the first time I hit the |
|
Please when doing substantial doc changes, run the doc build before creating the PR. This one broke the build. Thanks! |
|
Fixed in #10413 |
|
Thanks @gsmet! |
|
Sorry for this @gsmet, I only run doc build in case of new doc, or when adding links to check them. Maybe we can add a doc CI workflow, it should be easy to create one and avoid such issue. |
4 participants
Fixes #10364
I'll open a PR on the quickstart to add this later.