Use the AWS SDK BOM to avoid inconsistent versions and upgrade to 2.13.46 - Fix various other version alignments #10346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the platform, we have inconsistent versions of various artifacts from the AWS SDK, better fix it once and for all.
boring-cyborg
bot
added
the
area/dependencies
We need it to be consistent with the other httpclient artifacts.
We need it to be consistent with mockito-core.
It ends up being inconsistent in the platform.
It needs to be consistent with maven-core.
|
@gsmet thanks for the heads up. Having this will make it easier for us to rely on Quarkus for AWS artifacts management. However, there always be a chance that Camel core chooses an incompatible version. |
gsmet
changed the title
gsmet
changed the title
|
@ppalaga yeah, that will remain a problem but it's already one as we are having inconsistent versions of the SDK in the Quarkus platform BOM. |
aloubyansky
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the platform, we have inconsistent versions of various artifacts from
the AWS SDK, better fix it once and for all.
I tested the platform with this forced and it worked OK.
/cc @quarkusio/camel FYI. I also think you should drop the override of the AWS SDK version in your Camel Quarkus project as they are not properly enforced fully in the platform and will be ignored starting with this commit.
I plan to backport this for 1.6.0.Final except if there is a significant issue.