Skip to content

Add a section about the redirection to the OIDC web-app docs #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Add a section about the redirection to the OIDC web-app docs #10321

merged 1 commit into from
Jun 30, 2020

Conversation

@sberyozkin
Copy link
Member

This update follows the discussion on the forum, some clarification about the way quarkus-oidc handles the redirection will help the users. CC @emmanuelbernard

@sberyozkin sberyozkin added this to the 1.7.0 - master milestone Jun 27, 2020
gastaldi
gastaldi requested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor fixes

@sberyozkin
Copy link
Member Author

Hi @gastaldi Thanks for cleaning it up. cheers

gastaldi
gastaldi approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash your commits before merging it 👍

@gsmet gsmet force-pushed the oidc_redirect_uri_docs branch from f494e6b to 39911b4 Compare June 30, 2020 08:02
@gsmet
Copy link
Member

gsmet commented Jun 30, 2020

I squashed the commits, let's merge.

@gsmet gsmet merged commit ebaae44 into quarkusio:master Jun 30, 2020
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.0.Final Jun 30, 2020
@sberyozkin sberyozkin deleted the oidc_redirect_uri_docs branch September 16, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

@pedroigor pedroigor Awaiting requested review from pedroigor

Assignees

No one assigned

Labels

area/documentation

Projects

None yet

Milestone

1.6.0.Final

Development

Successfully merging this pull request may close these issues.

3 participants

@sberyozkin @gsmet @gastaldi