Gcp HTTP functions improvements #10293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patriot1burke @gsmet I forgot to send this PR, sorry, it's a bit later but it align the GCF HTTP binging with the other extension (regarding deployment) and more important, it set this extension as experimental so I would like it to be merged asap and backported to 1.6. |
gsmet
requested changes
Jun 26, 2020
It uses Quarkus Vert.x instead of a function invoker so it is not testing the Functon infrastructure.
loicmathieu
force-pushed
the
gcp/http-functions-improvements
branch
from
45e2115 to
66a349a
Compare
|
@gsmet PR updated based on your requested changes. |
gsmet
approved these changes
Jun 26, 2020
gsmet
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small enhancement to the Google Cloud Functions HTTP bindings: