Skip to content

Strip trailing forward slash from OIDC URL #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Strip trailing forward slash from OIDC URL #10239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ private TenantConfigContext createTenantContext(Vertx vertx, OidcTenantConfig oi
}

// Base IDP server URL
options.setSite(oidcConfig.getAuthServerUrl().get());
String authServerUrl = oidcConfig.getAuthServerUrl().get();
if (authServerUrl.endsWith("/")) {
authServerUrl = authServerUrl.substring(0, authServerUrl.length() - 1);
}
options.setSite(authServerUrl);
// RFC7662 introspection service address
if (oidcConfig.getIntrospectionPath().isPresent()) {
options.setIntrospectionPath(oidcConfig.getIntrospectionPath().get());
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/oidc/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Configuration file
quarkus.oidc.auth-server-url=${keycloak.ssl.url}/realms/quarkus
quarkus.oidc.auth-server-url=${keycloak.ssl.url}/realms/quarkus/
quarkus.oidc.client-id=quarkus-app
quarkus.oidc.token.principal-claim=email
quarkus.http.cors=true
Expand Down