Skip to content

Conversation

@yurloc
Copy link
Contributor

@yurloc yurloc commented Jun 22, 2020

No description provided.

@geoand
Copy link
Contributor

geoand commented Jun 22, 2020

Thanks!

Do you also plan to update the corresponding quickstart?

@geoand
Copy link
Contributor

geoand commented Jun 22, 2020

Asking because I see that the docs changes are different from what the quickstarts has for tests packages

@yurloc
Copy link
Contributor Author

yurloc commented Jun 23, 2020

@geoand Good catch. I think the article should be consistent with the quickstart source code. I'll update the PR.

@ge0ffrey the quickstart uses org.acme.optaplanner as the root package. I'll update the article to the same instead of just org.acme, ok?

@ge0ffrey
Copy link
Contributor

@yurloc Yes, thanks

@yurloc yurloc force-pushed the quickstart-optaplanner-typos branch from c8ba853 to 8ff862c Compare June 23, 2020 16:50
@yurloc
Copy link
Contributor Author

yurloc commented Jun 23, 2020

@geoand I haven't touched the quickstart code in the other repo. Instead I made sure that this quickstart article is consistent with the solution in the quickstart repo.

@geoand
Copy link
Contributor

geoand commented Jun 23, 2020

Cool, thanks!

@geoand geoand merged commit 8ff4366 into quarkusio:master Jun 23, 2020
@yurloc yurloc deleted the quickstart-optaplanner-typos branch June 24, 2020 13:28
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants