Skip to content

Conversation

@phillip-kruger
Copy link
Member

This PR updates the SmallRye GraphQL version to 1.0.4
see https://github.com/smallrye/smallrye-graphql/releases/tag/1.0.4 for changes

It also fix the GET requests in the extension to comply with https://github.com/APIs-guru/graphql-over-http

Signed-off-by: Phillip Kruger [email protected]

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jun 21, 2020
@phillip-kruger phillip-kruger requested a review from gsmet June 21, 2020 21:39
@jaikiran
Copy link
Member

Failure looks related:

2020-06-21T23:04:34.6679788Z [INFO] Running io.quarkus.it.smallrye.graphql.GreetingsResourceTestIT
2020-06-21T23:04:34.6707340Z 2020-06-21 23:04:34,625 ERROR [io.sma.graphql] (vert.x-worker-thread-1) SRGQL012000: Data Fetching Error: java.lang.RuntimeException: Can not load class [java.util.List]
2020-06-21T23:04:34.6743698Z 	at io.quarkus.smallrye.graphql.runtime.spi.QuarkusClassloadingService.loadClass(QuarkusClassloadingService.java:47)
2020-06-21T23:04:34.6840062Z 	at io.smallrye.graphql.execution.datafetcher.CollectionCreator.newCollection(CollectionCreator.java:27)
2020-06-21T23:04:34.6845795Z 	at io.smallrye.graphql.execution.datafetcher.helper.AbstractHelper.recursiveTransformCollection(AbstractHelper.java:212)
2020-06-21T23:04:34.6848503Z 	at io.smallrye.graphql.execution.datafetcher.helper.AbstractHelper.recursiveTransform(AbstractHelper.java:74)
2020-06-21T23:04:34.6857122Z 	at io.smallrye.graphql.execution.datafetcher.helper.FieldHelper.transformResponse(FieldHelper.java:30)
2020-06-21T23:04:34.6868951Z 	at io.smallrye.graphql.execution.datafetcher.PropertyDataFetcher.get(PropertyDataFetcher.java:29)
2020-06-21T23:04:34.6883708Z 	at graphql.execution.instrumentation.dataloader.DataLoaderDispatcherInstrumentation.lambda$instrumentDataFetcher$0(DataLoaderDispatcherInstrumentation.java:86)
2020-06-21T23:04:34.6912095Z 	at graphql.execution.ExecutionStrategy.fetchField(ExecutionStrategy.java:277)
2020-06-21T23:04:34.6918558Z 	at graphql.execution.ExecutionStrategy.resolveFieldWithInfo(ExecutionStrategy.java:202)
2020-06-21T23:04:34.6981164Z 	at graphql.execution.AsyncExecutionStrategy.execute(AsyncExecutionStrategy.java:74)
2020-06-21T23:04:34.6987113Z 	at graphql.execution.ExecutionStrategy.completeValueForObject(ExecutionStrategy.java:659)
2020-06-21T23:04:34.7011994Z 	at graphql.execution.ExecutionStrategy.completeValue(ExecutionStrategy.java:443)
2020-06-21T23:04:34.7022734Z 	at graphql.execution.ExecutionStrategy.completeField(ExecutionStrategy.java:393)
2020-06-21T23:04:34.7028768Z 	at graphql.execution.ExecutionStrategy.lambda$resolveFieldWithInfo$0(ExecutionStrategy.java:204)
2020-06-21T23:04:34.7034790Z 	at java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:680)
2020-06-21T23:04:34.7040018Z 	at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:658)
2020-06-21T23:04:34.7048680Z 	at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2094)
2020-06-21T23:04:34.7054292Z 	at graphql.execution.ExecutionStrategy.resolveFieldWithInfo(ExecutionStrategy.java:203)
2020-06-21T23:04:34.7059269Z 	at graphql.execution.ExecutionStrategy.resolveField(ExecutionStrategy.java:175)
2020-06-21T23:04:34.7068734Z 	at graphql.execution.AsyncSerialExecutionStrategy.lambda$execute$1(AsyncSerialExecutionStrategy.java:41)
2020-06-21T23:04:34.7075619Z 	at graphql.execution.Async.eachSequentiallyImpl(Async.java:77)
2020-06-21T23:04:34.7092022Z 	at graphql.execution.Async.eachSequentially(Async.java:66)
2020-06-21T23:04:34.7118925Z 	at graphql.execution.AsyncSerialExecutionStrategy.execute(AsyncSerialExecutionStrategy.java:36)
2020-06-21T23:04:34.7127351Z 	at graphql.execution.Execution.executeOperation(Execution.java:167)
2020-06-21T23:04:34.7137795Z 	at graphql.execution.Execution.execute(Execution.java:108)
2020-06-21T23:04:34.7138807Z 	at graphql.GraphQL.execute(GraphQL.java:598)
2020-06-21T23:04:34.7146431Z 	at graphql.GraphQL.parseValidateAndExecute(GraphQL.java:529)
2020-06-21T23:04:34.7165988Z 	at graphql.GraphQL.executeAsync(GraphQL.java:493)
2020-06-21T23:04:34.7174940Z 	at graphql.GraphQL.execute(GraphQL.java:426)
2020-06-21T23:04:34.7180386Z 	at io.smallrye.graphql.execution.ExecutionService.execute(ExecutionService.java:124)
2020-06-21T23:04:34.7186901Z 	at io.smallrye.graphql.execution.ExecutionService.execute(ExecutionService.java:96)
2020-06-21T23:04:34.7206844Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.doRequest(SmallRyeGraphQLExecutionHandler.java:158)
2020-06-21T23:04:34.7217078Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.doRequest(SmallRyeGraphQLExecutionHandler.java:151)
2020-06-21T23:04:34.7237764Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.handlePost(SmallRyeGraphQLExecutionHandler.java:94)
2020-06-21T23:04:34.7275367Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.doHandle(SmallRyeGraphQLExecutionHandler.java:75)
2020-06-21T23:04:34.7288070Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.handle(SmallRyeGraphQLExecutionHandler.java:53)
2020-06-21T23:04:34.7297130Z 	at io.quarkus.smallrye.graphql.runtime.SmallRyeGraphQLExecutionHandler.handle(SmallRyeGraphQLExecutionHandler.java:32)
2020-06-21T23:04:34.7297689Z 	at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48)
2020-06-21T23:04:34.7302780Z 	at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:313)
2020-06-21T23:04:34.7312291Z 	at io.vertx.core.impl.TaskQueue.run(TaskQueue.java:76)
2020-06-21T23:04:34.7324065Z 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2020-06-21T23:04:34.7332090Z 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2020-06-21T23:04:34.7340431Z 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
2020-06-21T23:04:34.7353834Z 	at java.lang.Thread.run(Thread.java:834)
2020-06-21T23:04:34.7364997Z 	at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:497)
2020-06-21T23:04:34.7432869Z 	at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:193)
2020-06-21T23:04:34.7441505Z Caused by: java.security.PrivilegedActionException: java.lang.ClassNotFoundException: java.util.List
2020-06-21T23:04:34.7447590Z 	at java.security.AccessController.doPrivileged(AccessController.java:119)
2020-06-21T23:04:34.7472028Z 	at io.quarkus.smallrye.graphql.runtime.spi.QuarkusClassloadingService.loadClass(QuarkusClassloadingService.java:41)
2020-06-21T23:04:34.7472642Z 	... 45 more
2020-06-21T23:04:34.7476285Z Caused by: java.lang.ClassNotFoundException: java.util.List
2020-06-21T23:04:34.7486886Z 	at com.oracle.svm.core.hub.ClassForNameSupport.forName(ClassForNameSupport.java:60)
2020-06-21T23:04:34.7490868Z 	at java.lang.Class.forName(DynamicHub.java:1197)
2020-06-21T23:04:34.7500016Z 	at io.smallrye.graphql.spi.ClassloadingService.loadClass(ClassloadingService.java:59)
2020-06-21T23:04:34.7510904Z 	at io.quarkus.smallrye.graphql.runtime.spi.QuarkusClassloadingService.lambda$loadClass$0(QuarkusClassloadingService.java:43)
2020-06-21T23:04:34.7518722Z 	at java.security.AccessController.doPrivileged(AccessController.java:117)
2020-06-21T23:04:34.7523320Z 	... 46 more
2020-06-21T23:04:34.7523447Z 
2020-06-21T23:04:34.7701161Z [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.087 s <<< FAILURE! - in io.quarkus.it.smallrye.graphql.GreetingsResourceTestIT
2020-06-21T23:04:34.7713515Z [ERROR] test  Time elapsed: 0.087 s  <<< FAILURE!
2020-06-21T23:04:34.7721631Z java.lang.AssertionError: 
2020-06-21T23:04:34.7721973Z 1 expectation failed.
2020-06-21T23:04:34.7728846Z Response body doesn't match expectation.
2020-06-21T23:04:34.7734639Z Expected: a string containing "Goeie more"
2020-06-21T23:04:34.7772566Z   Actual: {"errors":[{"message":"Server Error","locations":[{"line":23,"column":5}],"path":["load","hellos"],"extensions":{"exception":"java.lang.RuntimeException","classification":"DataFetchingException","code":"runtime"}}],"data":{"load":{"language":"afr","hellos":null}}}

@phillip-kruger phillip-kruger requested a review from jmartisk June 22, 2020 06:56
@phillip-kruger phillip-kruger requested a review from jmartisk June 22, 2020 17:10
@gastaldi gastaldi added this to the 1.6.0 - master milestone Jun 23, 2020
@gastaldi gastaldi merged commit 7371216 into quarkusio:master Jun 23, 2020
@phillip-kruger phillip-kruger deleted the smallrye-graphql-update branch July 18, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file area/smallrye

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants