Make YAML configuration work for Bootstrap Config #10070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/config
area/core
area/spring
|
@geoand it looks safe enough for a backport, WDYT? |
|
@gsmet yeah, it's completely safe |
gastaldi
reviewed
Jun 17, 2020
...rc/main/java/io/quarkus/deployment/builditem/AdditionalBootstrapConfigProviderBuildItem.java
Outdated
Show resolved
Hide resolved
gastaldi
approved these changes
Jun 17, 2020
...n/java/io/quarkus/deployment/builditem/AdditionalBootstrapConfigSourceProviderBuildItem.java
Show resolved
Hide resolved
dmlloyd
approved these changes
Jun 17, 2020
geoand
added
the
triage/waiting-for-ci
|
@geoand This doesn't cover custom We use a custom one to merge multiple yaml files (from maven submodules) that also contain |
|
@famod no it does not. But this PR was only for bootstrap config anyway, not for build-time config. |
|
Ah, now I understand. Thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9973
The idea here to allow an extension to register which
ConfigSourceProvidercan work in Bootstrap Config, because we (correctly) don't do auto-discovery when building the Bootstrap Config