Add openj9 images to the S2iBaseJavaImage #10058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great thanks! I'll take a look tomorrow. cc @Ladicek |
Contributor
Author
|
yw :) |
Contributor
Author
|
I am wondering if there is any question that I could do in this task. |
Contributor
|
Well, if you have access to an s390x machine, you can pull the images 😁 But the OpenJ9 images are built from the same source as the OpenJDK ones: https://github.com/jboss-container-images/openjdk, and I've verified yesterday that the RHEL 8-based OpenJ9 11 image has the same scripts with the same env vars, so I think it's fine. |
Ladicek
approved these changes
Jun 17, 2020
Contributor
|
Great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10056
/cc @geoand @iocanel