Define layout.strategy on HibernateSearchElasticsearchRecorder#contributeBackendBuildTimeProperties

[vitor-cardoso-tdx]

Description
I think that we should have the possibility to choose our custom layout.strategy through quarkus configuration. There are some situations that can be useful to use a custom layout like:https://docs.jboss.org/hibernate/search/6.0/reference/en-US/html_single/#backend-elasticsearch-indexlayout.

Implementation ideas
Something like this:

private void contributeBackendBuildTimeProperties(BiConsumer<String, Object> propertyCollector, String backendName,
                ElasticsearchBackendBuildTimeConfig elasticsearchBackendConfig) {
            addBackendConfig(propertyCollector, backendName, BackendSettings.TYPE,
                    ElasticsearchBackendSettings.TYPE_NAME);
            addBackendConfig(propertyCollector, backendName, **ElasticsearchBackendSettings.LAYOUT_STRATEGY,
                    elasticsearchBackendConfig.layout);**
            addBackendConfig(propertyCollector, backendName, ElasticsearchBackendSettings.VERSION,
                    elasticsearchBackendConfig.version);
            addBackendConfig(propertyCollector, backendName,
                    ElasticsearchBackendSettings.ANALYSIS_CONFIGURER,
                    elasticsearchBackendConfig.analysis.configurer,
                    Optional::isPresent, c -> c.get().getName());
        }

With the property:
quarkus.hibernate-search.elasticsearch.layout.strategy=[the custom layout bean that implements org.hibernate.search.backend.elasticsearch.mapping.TypeNameMappingStrategyName.IndexLayoutStrategy]

[quarkusbot]

/cc @gsmet @yrodiere
/cc @gsmet @Sanne

[yrodiere]

That's certainly doable. Out of curiosity, what forces you to rely on this feature? Don't you have complete control over the name and aliases of your Elasticsearch indexes?

[vitor-cardoso-tdx]

Hi @yrodiere ,

So the problem is the default impl of IndexLayoutStrategy from Hibernate Search don't allow to manipulate the index /alias naming conventions.
In my context I want to apply versioning on indexes and use the "blue/green" with alias, for this works I need to implement my custom IndexLayoutStrategy.

Right now Quarkus don't allow to use both persistence.xml and application.properties to define the same set of properties related with hibernate-search.
Right now I was forced to define all of this in persistence.xml in order to work:

<property name="hibernate.search.default_backend" value="_quarkus_"/>
      <property name="hibernate.search.backends._quarkus_.layout.strategy" value="[CustomLayoutStrategy]"/>
      <property name="hibernate.search.backends._quarkus_.type" value="elasticsearch"/>
      <property name="hibernate.search.backends._quarkus_.index_defaults.schema_management.minimal_required_status" value="yellow"/>
      <property name="hibernate.search.backends._quarkus_.analysis.configurer" value="[CustomAnalysisConfigurer]"/>

In that in mind and looking for current code, for me makes totally sense in a short term solution to provide this new property. In a long term solution Quarkus should know how to merge properties from both persistence.xml (to apply some properties not provided from Quarkus impl) and application.properties.

[yrodiere]

In my context I want to apply versioning on indexes and use the "blue/green" with alias, for this works I need to implement my custom IndexLayoutStrategy.

Right, but that's possible with the default layout strategy, which defines two aliases per index: <indexName>-read and <indexName>-write. You just have to make these aliases point somewhere else to implement a "blue/green" swap.

So the problem is the default impl of IndexLayoutStrategy from Hibernate Search don't allow to manipulate the index /alias naming conventions.

Ok, so it's just about using different naming conventions. Understood.