Infinispan cache JPA tests still failing from time to time

[gsmet]

Just had this one on CI:

2019-02-02T13:15:58.0732707Z   Actual: Oops, shit happened, No boot for you! java.lang.RuntimeException: [org.jboss.shamrock.example.infinispancachejpa.Country] expected Counts{puts=1, hits=0, misses=1, numElements=1} second level cache count, instead got: Counts{puts=1, hits=0, misses=1, numElements=2}
2019-02-02T13:15:58.0733096Z 	java.lang.RuntimeException: [org.jboss.shamrock.example.infinispancachejpa.Country] expected Counts{puts=1, hits=0, misses=1, numElements=1} second level cache count, instead got: Counts{puts=1, hits=0, misses=1, numElements=2}
2019-02-02T13:15:58.0733475Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertCountEquals(InfinispanCacheJPAFunctionalityTestEndpoint.java:735)
2019-02-02T13:15:58.0734341Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertRegionStats(InfinispanCacheJPAFunctionalityTestEndpoint.java:718)
2019-02-02T13:15:58.0737039Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.verifyFindCountryByNaturalId(InfinispanCacheJPAFunctionalityTestEndpoint.java:157)
2019-02-02T13:15:58.0737421Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.testMaxIdle(InfinispanCacheJPAFunctionalityTestEndpoint.java:115)
2019-02-02T13:15:58.0737778Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doStuffWithHibernate(InfinispanCacheJPAFunctionalityTestEndpoint.java:72)
2019-02-02T13:15:58.0738111Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doGet(InfinispanCacheJPAFunctionalityTestEndpoint.java:47)

[gsmet]

@galderz I commented the assertion again here a25c216 to get master stable again.

[galderz]

Looking into it

[galderz]

Seems even with manual time adjustments, time based evictions are also eventually consistent. I already applied a similar fix to size based tests, so the same fix should be applied here too. PR coming shortly.

[galderz]

Sent PR #746

[gsmet]

This is still not fixed.

We just had this failure on CI:

2019-02-06T12:34:57.9113932Z 	java.lang.RuntimeException: [org.jboss.shamrock.example.infinispancachejpa.Person] expected Counts{puts=4, hits=0, misses=4, numElements=4} second level cache count, instead got: Counts{puts=0, hits=0, misses=4, numElements=0}
2019-02-06T12:34:57.9147623Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertCountEquals(InfinispanCacheJPAFunctionalityTestEndpoint.java:734)
2019-02-06T12:34:57.9148069Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.assertRegionStats(InfinispanCacheJPAFunctionalityTestEndpoint.java:729)
2019-02-06T12:34:57.9170794Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.verifyFindByIdPersons(InfinispanCacheJPAFunctionalityTestEndpoint.java:462)
2019-02-06T12:34:57.9171538Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.testReadOnly(InfinispanCacheJPAFunctionalityTestEndpoint.java:438)
2019-02-06T12:34:57.9229194Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doStuffWithHibernate(InfinispanCacheJPAFunctionalityTestEndpoint.java:60)
2019-02-06T12:34:57.9229604Z 	at org.jboss.shamrock.example.infinispancachejpa.InfinispanCacheJPAFunctionalityTestEndpoint.doGet(InfinispanCacheJPAFunctionalityTestEndpoint.java:46)

[gsmet]

I'm commenting the assertions again.

[galderz]

Add a new PR to deal with potential put from DB load too close after region invalidation.

[galderz]

Even after the PR gets merged leave this issue open for a few days in case it reappears.

[gsmet]

This one has been fixed.