Redis Client: support timeout as double instead of integer in BLPOP and BRPOP

[RobertoUa]

Describe the bug

Currently, the minimum timeout is 1 second, because timeout type is int. But Redis supports double, so it should be possible to pass 0.1 to use timeout of 100ms

docs: https://redis.io/docs/latest/commands/brpop/

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @Ladicek (redis), @cescoffier (redis), @machi1990 (redis)

[geoand]

Currently, the minimum timeout is 1 second, because timeout type is int

Can you please provide some details on where you saw this?

[RobertoUa]

notice timeout.toSeconds() here https://github.com/quarkusio/quarkus/blob/main/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/runtime/datasource/AbstractListCommands.java#L143

https://github.com/quarkusio/quarkus/pull/48596/files

[geoand]

Oh, good point.

cc @Ladicek

[Ladicek]

I think you mentioned this is since Redis 6 -- I wonder where did you find that info? I don't think we particularly case about Redis < 7, but still...

[RobertoUa]

I think you mentioned this is since Redis 6 -- I wonder where did you find that info? I don't think we particularly case about Redis < 7, but still...

I provided a link to docs. It mentions it there.
Here's the link again: https://redis.io/docs/latest/commands/brpop/

Starting with Redis version 6.0.0: timeout is interpreted as a double instead of an integer

[Ladicek]

Ah it's there in the history section! Sorry, I totally missed that.

[jack5505]

Can I take this issue to fix it. And what should I do I need to bring it back to old code

[Ladicek]

Feel free to submit a PR. I'm currently finishing some other work and if noone beats me to it, I expect to be able to get to this issue next week, hopefully.