Can not post body to custom management endpoint in DEV mode

[lschmierer]

Describe the bug

Hi, I am trying to accept simple plain/text on a post endpoint.

class Management {
    fun registerManagementRoutes(@Observes mi: ManagementInterface) {
        mi.router()
            .post("/test")
            // .handler(BodyHandler.create()) // does not change anything
            .handler { rc: RoutingContext ->
                val message = rc.body().asString()
                rc.response().end("Received: $message")
            }
    }
}

Expected behavior

curl -X POST http://localhost:9000/test -H "Content-Type: plain/text" -d hello --verbose

should return "Received: hello"

Actual behavior

Running

curl -X POST http://localhost:9000/test -H "Content-Type: plain/text" -d hello --verbose

the server just does not accepts or routes the request, my handler is never called.

curl -X POST http://localhost:9000/test -H "Content-Type: application/x-www-form-urlencoded" -d hello --verbose

on the other hand gives

Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying [::1]:9000...
* connect to ::1 port 9000 failed: Connection refused
*   Trying 127.0.0.1:9000...
* Connected to localhost (127.0.0.1) port 9000
> POST /test HTTP/1.1
> Host: localhost:9000
> User-Agent: curl/8.4.0
> Accept: */*
> Content-Type: application/x-www-form-urlencoded
> Content-Length: 5
> 
< HTTP/1.1 500 Internal Server Error
< content-type: text/plain; charset=utf-8
< content-length: 2402
< 

500 - Internal Server Error
---------------------------

Details:
        Error id d1513df2-a061-4b0e-990b-f3b72f260633-1, java.lang.IllegalStateException: Request has already been read
Stack:
        java.lang.IllegalStateException: Request has already been read
        at io.vertx.core.http.impl.Http1xServerRequest.checkEnded(Http1xServerRequest.java:733)
        at io.vertx.core.http.impl.Http1xServerRequest.setExpectMultipart(Http1xServerRequest.java:522)
        at io.vertx.core.http.impl.HttpServerRequestWrapper.setExpectMultipart(HttpServerRequestWrapper.java:190)
        at io.vertx.core.http.impl.HttpServerRequestWrapper.setExpectMultipart(HttpServerRequestWrapper.java:190)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl$BHandler.<init>(BodyHandlerImpl.java:230)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:126)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:45)
        at io.quarkus.vertx.http.runtime.VertxHttpRecorder$18.handle(VertxHttpRecorder.java:1622)
        at io.quarkus.vertx.http.runtime.VertxHttpRecorder$18.handle(VertxHttpRecorder.java:1593)
        at io.vertx.ext.web.impl.RouteState.handleContext(RouteState.java:1283)
        at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:177)
        at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:151)
        at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$5.handle(VertxHttpHotReplacementSetup.java:206)
        at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$5.handle(VertxHttpHotReplacementSetup.java:194)
        at io.vertx.core.impl.future.FutureImpl$4.onSuccess(FutureImpl.java:176)
        at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:60)
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:998)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1583)
* Connection #0 to host localhost left intact

How to Reproduce?

quarkus-management-vertx.zip

Output of uname -a or ver

Darwin DaMac-J9QVF643HM 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:54 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6030 arm64

Output of java -version

openjdk version "22.0.2" 2024-07-16 OpenJDK Runtime Environment (build 22.0.2+9-70) OpenJDK 64-Bit Server VM (build 22.0.2+9-70, mixed mode, sharing)

Quarkus version or git rev

reproduced on 3.15, 3.20, 3.23

Build tool (ie. output of mvnw --version or gradlew --version)

------------------------------------------------------------ Gradle 8.13 ------------------------------------------------------------ Build time: 2025-02-25 09:22:14 UTC Revision: 073314332697ba45c16c0a0ce1891fa6794179ff Kotlin: 2.0.21 Groovy: 3.0.22 Ant: Apache Ant(TM) version 1.10.15 compiled on August 25 2024 Launcher JVM: 22.0.2 (Oracle Corporation 22.0.2+9-70) Daemon JVM: /Users/lukas.schmierer/Library/Java/JavaVirtualMachines/openjdk-22.0.2/Contents/Home (no JDK specified, using current Java home) OS: Mac OS X 14.4 aarch64

Additional information

No response

[quarkus-bot]

/cc @geoand (kotlin)

[lschmierer]

I just made a very strange observation:
When trying

curl -X POST http://localhost:9000/test -H "Content-Type: application/x-www-form-urlencoded" -d hello --verbose

multiple times, it sometimes randomly works (about every 2nd try)

➜  quarkus-management-vertx curl -X POST http://localhost:9000/test -H "Content-Type: application/x-www-form-urlencoded" -d hello --verbose
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying [::1]:9000...
* connect to ::1 port 9000 failed: Connection refused
*   Trying 127.0.0.1:9000...
* Connected to localhost (127.0.0.1) port 9000
> POST /test HTTP/1.1
> Host: localhost:9000
> User-Agent: curl/8.4.0
> Accept: */*
> Content-Type: application/x-www-form-urlencoded
> Content-Length: 5
> 
< HTTP/1.1 500 Internal Server Error
< content-type: text/plain; charset=utf-8
< content-length: 2402
< 

500 - Internal Server Error
---------------------------

Details:
        Error id 6c8005b6-ac52-49da-8fd6-d7b1754748e3-5, java.lang.IllegalStateException: Request has already been read
Stack:
        java.lang.IllegalStateException: Request has already been read
        at io.vertx.core.http.impl.Http1xServerRequest.checkEnded(Http1xServerRequest.java:733)
        at io.vertx.core.http.impl.Http1xServerRequest.setExpectMultipart(Http1xServerRequest.java:522)
        at io.vertx.core.http.impl.HttpServerRequestWrapper.setExpectMultipart(HttpServerRequestWrapper.java:190)
        at io.vertx.core.http.impl.HttpServerRequestWrapper.setExpectMultipart(HttpServerRequestWrapper.java:190)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl$BHandler.<init>(BodyHandlerImpl.java:230)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:126)
        at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:45)
        at io.quarkus.vertx.http.runtime.VertxHttpRecorder$18.handle(VertxHttpRecorder.java:1622)
        at io.quarkus.vertx.http.runtime.VertxHttpRecorder$18.handle(VertxHttpRecorder.java:1593)
        at io.vertx.ext.web.impl.RouteState.handleContext(RouteState.java:1283)
        at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:177)
        at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:151)
        at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$5.handle(VertxHttpHotReplacementSetup.java:206)
        at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$5.handle(VertxHttpHotReplacementSetup.java:194)
        at io.vertx.core.impl.future.FutureImpl$4.onSuccess(FutureImpl.java:176)
        at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:60)
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:998)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1570)
* Connection #0 to host localhost left intact
➜  quarkus-management-vertx curl -X POST http://localhost:9000/test -H "Content-Type: application/x-www-form-urlencoded" -d hello --verbose
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying [::1]:9000...
* connect to ::1 port 9000 failed: Connection refused
*   Trying 127.0.0.1:9000...
* Connected to localhost (127.0.0.1) port 9000
> POST /test HTTP/1.1
> Host: localhost:9000
> User-Agent: curl/8.4.0
> Accept: */*
> Content-Type: application/x-www-form-urlencoded
> Content-Length: 5
> 
< HTTP/1.1 200 OK
< content-length: 15
< 
* Connection #0 to host localhost left intact
Received: hello%                                 

[geoand]

cc @cescoffier

[cescoffier]

It’s a known issue due to having multiple body handlers. I never found the time to investigate.

[geoand]

🙏🏽

[lschmierer]

@cescoffier is there any known workaround? Can I somehow remove that body handler for my routes?

Or is actually nobody really using these custom management endpoints on application level?

[cescoffier]

No real workaround.

It only happens with routes reading bodies. The ungly workaround is to pass the data as query parameters.

[cescoffier]

Also, I think it only happens when the management interface is not mounted on its own server.

[lschmierer]

I can confirm that it also happens if the management interface is running on :9000 (which I think is its own server?)

Am I right to assume that this is just not a common thing to have management APIs set up this way? Or at least it’s not recommended?
But there seems also no other way to have a separate port for things like internal APIs that I don’t want to expose. What would be the Quarkus way of doing sth like this? A dedicated „management/admin service“?

[cescoffier]

That's the role of the management interface, it's a bug. Investigations or ideas are more than welcome.

The last time I received a report, I was unable to reproduce it in a test using Quarkus.

[cescoffier]

Just to explain, if I create a new app with:

public class ManagementInterfaceRoute {

    public void init(@Observes ManagementInterface itf) {
        itf.router().post("/q/test")
                .handler(rc -> {
                    String message = rc.body().asString();
                    rc.response().end("Received: " + message);
                });
    }
}

And 2 tests:

@QuarkusTest
class GreetingResourceTest {

    @Test
    void testPostOnManagementInterface() {
        given()
                .body("Hello Management Interface")
                .when().post("http://localhost:9001/q/test")
                .then()
                .statusCode(200)
                .body(is("Received: Hello Management Interface"));
    }

    @Test
    void testPostOnManagementInterfaceAsForm() {
        given()
                .formParam("name", "John Doe")
                .when().post("http://localhost:9001/q/test")
                .then()
                .statusCode(200)
                .body(is("Received: name=John%20Doe"));
    }

}

It passes....

My config only contains: quarkus.management.enabled=true