Proxied synthetic bean seems to proxy to two different super classes

[HerrDerb]

Describe the bug

I have an extension that produces a synthetic bean (in the actual project I have some handling with qualifiers and so on).
This synthetic bean has to be proxied to apply e.g. @Retry which otherwise, would be ignored.
There is a weird behavior which I found as that bean extends another class.

It seems that when I call my been over the method which is annotated with @Retry I do access another super class than when I access the superclass over a non-annotated method.,leading to a unexpected behaviour/return value.

My build step method

    @BuildStep
    @Record(RUNTIME_INIT)
    public void registerClients(BuildProducer<SyntheticBeanBuildItem> syntheticBeans, ClientRecorder recorder) {

        log.info("Registering Azure FileShare Client");
        syntheticBeans.produce(SyntheticBeanBuildItem.configure(AdvancedClient.class)
                .scope(ApplicationScoped.class)
                .setRuntimeInit()
                .injectInterceptionProxy()
                .createWith(recorder.createAdvancedClientWith("test"))
                .done());
    }
}

my creator method

   public Function<SyntheticCreationalContext<AdvancedClient>, AdvancedClient> createAdvancedClientWith(String name) {
        return context -> {
            log.info("Creating advanced client for {}", name);
            return (AdvancedClient) context.getInterceptionProxy().create(new AdvancedClient(name));
        };
    }

My bean

@Slf4j
public class AdvancedClient extends BaseClient {

    AdvancedClient() {
        super(null);
        log.info("Initializing AdvancedClient with noArgs constructor");
    }

    public AdvancedClient(String name) {
        super(name);
        log.info("Initializing AdvancedClient with name {}", name);
    }

    @Retry
    public String getProxiedName() {
        return getName();
    }
}

My superclass

@Getter
@RequiredArgsConstructor
public class BaseClient {
    private final String name;
}

Expected behavior

When calling getName() or getProxiedName() I expected both times the name given on the creator method.✅

Actual behavior

When calling getProxiedName() I do get the name given within the creator method.✅

When calling getName() I get null ❌

Is this intended behaviour and I did just understand something wrong?

How to Reproduce?

• Clone https://github.com/HerrDerb/quarkus-extension-playground.git
• Checkout branch syntetic-bean-issue
• Run tests in deployment module

Quarkus 3.21.4

[quarkus-bot]

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

[Ladicek]

Thanks for the reproducer, I'll take a look.

[Ladicek]

I think I know what happens. The interception proxy subclass only forwards intercepted methods, and it doesn't forward non-intercepted methods. Hence, the getName() method is only invoked on the interception proxy subclass, which obviously returns null. Instead, it should be forwarded to the delegate. That should be relatively straightforward to fix -- when generating the interception proxy subclass, we will also override non-intercepted methods and forward them to the delegate unconditionally.

[HerrDerb]

@Ladicek Thanks for looking into it that fast 🙂👍
Also what riddles me a bit is (I just added a commit for a different log level) is that the AdvancedService seems to be initialized 3x of which only 1 is the expected initialization of my synthetic bean.
Would you know what the others are?

Initializing AdvancedClient with noArgs constructor
Initializing AdvancedClient with name test
Initializing AdvancedClient with noArgs constructor

[Ladicek]

These are all expected:

1. The client proxy (because the bean is application scoped)
2. The actual bean instance
3. The interception proxy

[HerrDerb]

@Ladicek thanks for explaining and the fast fix 👍💪