Non-viable test classloader when running a group of tests (Class or Package) in VSCode

[ebullient]

Describe the bug

In VSCode, when running a group of tests (all tests in a class or all tests in a package), the tests fail with:

org.junit.jupiter.engine.execution.ConditionEvaluationException: Failed to evaluate condition [io.quarkus.test.junit.QuarkusTestExtension]: Non-viable test classloader, io.quarkus.test.junit.classloading.FacadeClassLoader@1bc715b8. Is this a re-run of a failing test?
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
        at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
        at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.IllegalStateException: Non-viable test classloader, io.quarkus.test.junit.classloading.FacadeClassLoader@1bc715b8. Is this a re-run of a failing test?
        at io.quarkus.test.junit.AbstractJvmQuarkusTestExtension.evaluateExecutionCondition(AbstractJvmQuarkusTestExtension.java:169)

If I run a single test, it passes.

Opening this at the request of @holly-cummins, I'm running into this while working on https://github.com/commonhaus/automation.

• Quarkus 3.22.3
• Language Support for Java(TM) by Red Hat (1.42.0)
• Test Runner for Java (0.43.1)

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[geoand]

@holly-cummins Is this similar or even a duplicate of the other issues we have with Eclipse?

[holly-cummins]

I need to investigate, but my initial instinct is that the cause is different. The symptom is obviously similar, and the workarounds are also similar. But with #47656, it seems like the Eclipse launcher is bypassing our JUnit interceptors, so the FacadeClassLoader never gets set as the TCCL – either that, or the FCL gets invoked, but it doesn't have a good enough classpath to do stuff with.

With this issue, it seems like our interceptor logic is being invoked ok, but it's actually being invoked too much. So the classloader is getting closed after the first test executes, and subsequent tests are stuck trying to run on a closed classloader. As well as fixing the actual problem, I clearly need to improve the error message, which is left over from a different problem.

[holly-cummins]

I may need to eat my words about this being a different issue. Turns out VS Code uses the Eclipse JUnit plugin under the covers. :) So this is the exact same issue. The fix to the Eclipse plugin has been merged, but I don't know when it will turn up in the VS Code plugins.

In the meantime, I have work to do, because my errors messages incorrecly detect Eclipse (because it is Eclipse) and helpfully share Eclipse-specific workarounds. That will be very confusing to users who didn't know they were using Eclipse. :)

[ebullient]

So we can use this issue for the VSCode word changes?