Problems with bom-platform for v. 3.19.3 for jUnit

[EsbenNedergaard]

Describe the bug

Problems with new quarkus bom: repo1.maven.org/maven2/io/quarkus/quarkus-bom/3.19.3/quarkus-bom-3.19.3.pom

It uses:
- junit-jupiter-api:5.10.5
- mockito-junit-jupiter:5.15.2

The problem is that mockito-junit-jupiter:5.15.2 requires junit-jupiter-api:5.11.4
- See https://mvnrepository.com/artifact/org.mockito/mockito-junit-jupiter/5.15.2

If you then do imports like this:

implementation platform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}") 

testImplementation 'org.junit.jupiter:junit-jupiter'
testImplementation 'org.mockito:mockito-junit-jupiter'

Then it leads to problems with errors like this:

org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not complete execution for Gradle Test Executor 1.
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:65)
	at java.base@21.0.4/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base@21.0.4/java.lang.reflect.Method.invoke(Method.java:580)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
	at jdk.proxy2/jdk.proxy2.$Proxy6.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
	at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: org.junit.platform.commons.JUnitException: TestEngine with ID 'junit-jupiter' failed to discover tests
	at app//org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.discoverEngineRoot(EngineDiscoveryOrchestrator.java:160)
	at app//org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.discoverSafely(EngineDiscoveryOrchestrator.java:134)
	at app//org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.discover(EngineDiscoveryOrchestrator.java:108)
	at app//org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.discover(EngineDiscoveryOrchestrator.java:80)
	at app//org.junit.platform.launcher.core.DefaultLauncher.discover(DefaultLauncher.java:110)
	at app//org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at app//org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:124)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:99)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:94)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
	... 16 more
// DROPPED REMAINING STACK TRACE FOR SECURITY REASONS

Expected behavior

That my i can use the versions of junit-jupiter-api & mockito-junit-jupiter controlled by quarkus in my build.gradle and still get my tests to run.

Actual behavior

I get exceptions like the one shown in the descprition.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

17

Quarkus version or git rev

3.19.3

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 8.13

Additional information

No response

[gsmet]

@EsbenNedergaard is the problem new in 3.19.3 for you?

From what I can see, Mockito has been relying on JUnit 5.11 for a while.

[EsbenNedergaard]

@gsmet the bug might have been there earlier but a while ago we decided to change to bom-platforming in the dependencies in our java libraries to use the ones present in Quarkus' bom and cleanup our gradles to not API import as much.

Which is probably why we first noticed it now since some of our libraries have had hard coded versions of j-unit that we have then gotten through them.

[gsmet]

OK. For now, we are stuck to older JUnit and I'm not sure if it's best to downgrade Mockito. What's your take on this?

If you can figure out a version of Mockito that would work, we could probably downgrade Mockito in future 3.20 LTS and 3.21.

Not sure how it will go in the future as we plan to upgrade to JUnit 5.12 at some point.

[EsbenNedergaard]

@gsmet seems like the newest version that does not require JUnit 5.11 is:
mockito-junit-jupiter:5.12.0 - https://mvnrepository.com/artifact/org.mockito/mockito-junit-jupiter/5.12.0

As from 5.13.0 and forward they require JUnit 5.11

[EsbenNedergaard]

@gsmet opened a PR with downgrade: #46931

[gsmet]

OK, I wonder if this is going to be in the way of our upcoming upgrade to JUnit 5.12.