Upgrade to GraalVM 19.3.0 / Java 8 edition

[gsmet]

I created this issue to gather notes about the next GraalVM upgrade.

Per Codrut Stancu from the GraalVM team on Zulip:

FYI this changeset oracle/graal@fa58e36 introduces a substitution for Field.getAnnotatedType() which conflicts with the Quarkus substitution in https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/graal/FieldReplacement.java. I think the Quarkus substitution for Field.getAnnotatedType() can be removed with the next GraalVM release. In fact, I think that the entire FieldReplacement.java can be removed. DONE!

Per Codrut again

FYI additional changes that Quarkus will need for GraalVM 19.3:

• Update Netty version to include Register sun.nio.ch.SelectorImpl fields for unsafe access. netty/netty#9631
• Additional command-line options --initialize-at-run->time=org.wildfly.common.net.CidrAddress,org.wildfly.common.net.Inet. This is needed due to a new restriction that prohibits the presence of java.net.Inet4Address in the image heap.

Note that this means an upgrade of Netty to 4.1.43.Final. Or another option is to port this patch https://github.com/netty/netty/pull/9631/files to Quarkus via usage of our reflection registration API but I'm not sure if we have allowUnsafeAccess support right now.

[loicmathieu]

This release should also add support for Java 11 on GraalVM.
So this means we also need to add test for this combination in the CI : Native on 11.

[gsmet]

Yeah or drop Java 8 and only test Java 11. /cc @dmlloyd

[loicmathieu]

Yeah or drop Java 8 and only test Java 11

As a lot of people still use Java 8 it depends if you are ready to take the risk !

[dmlloyd]

Hopefully people aren't using Java 8 for new projects :)

[loicmathieu]

Hopefully people aren't using Java 8 for new projects :)

You will be very surprised ... or disapointed :)

[gsmet]

Reopening, we haven't upgraded yet.

[gsmet]

/cc @cescoffier @dmlloyd please have a look at the added elements in the description. @cescoffier especially the Netty upgrade part for you.

[cstancu]

Additional patch required for GraalVM 19.3.0:

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java b/core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java
index 2f32e0d39..7da7aacd1 100644
--- a/core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java
+++ b/core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java
@@ -44,7 +44,7 @@ public class SubstrateAutoFeatureStep {
     static final String RUNTIME_REFLECTION = RuntimeReflection.class.getName();
     static final String BEFORE_ANALYSIS_ACCESS = Feature.BeforeAnalysisAccess.class.getName();
     static final String DYNAMIC_PROXY_REGISTRY = "com.oracle.svm.core.jdk.proxy.DynamicProxyRegistry";
-    static final String LOCALIZATION_SUPPORT = "com.oracle.svm.core.jdk.LocalizationSupport";
+    static final String LOCALIZATION_FEATURE = "com.oracle.svm.core.jdk.LocalizationFeature";
 
     @BuildStep
     SubstrateOutputBuildItem generateFeature(ClassOutputBuildItem output,
@@ -138,7 +138,7 @@ public class SubstrateAutoFeatureStep {
         }
 
         if (!resourceBundles.isEmpty()) {
-            ResultHandle locClass = overallCatch.loadClass(LOCALIZATION_SUPPORT);
+            ResultHandle locClass = overallCatch.loadClass(LOCALIZATION_FEATURE);
 
             ResultHandle params = overallCatch.marshalAsArray(Class.class, overallCatch.loadClass(String.class));
             ResultHandle registerMethod = overallCatch.invokeVirtualMethod(
diff --git a/extensions/vertx-core/runtime/src/main/java/io/quarkus/vertx/core/runtime/graal/JdkSubstitutions.java b/extensions/vertx-core/runtime/src/main/java/io/quarkus/vertx/core/runtime/graal/JdkSubstitutions.java
index 14afde0c9..612ecaa99 100644
--- a/extensions/vertx-core/runtime/src/main/java/io/quarkus/vertx/core/runtime/graal/JdkSubstitutions.java
+++ b/extensions/vertx-core/runtime/src/main/java/io/quarkus/vertx/core/runtime/graal/JdkSubstitutions.java
@@ -8,8 +8,9 @@ import java.util.function.BooleanSupplier;
 import com.oracle.svm.core.annotate.Alias;
 import com.oracle.svm.core.annotate.Substitute;
 import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.jdk.JDK8OrEarlier;
 
-@TargetClass(className = "sun.misc.URLClassPath$Loader")
+@TargetClass(className = "sun.misc.URLClassPath$Loader", onlyWith = JDK8OrEarlier.class)
 final class Target_sun_misc_URLClassPath$Loader {
 
     @Alias
@@ -17,7 +18,7 @@ final class Target_sun_misc_URLClassPath$Loader {
     }
 }
 
-@TargetClass(className = "sun.misc.URLClassPath$FileLoader")
+@TargetClass(className = "sun.misc.URLClassPath$FileLoader", onlyWith = JDK8OrEarlier.class)
 final class Target_sun_misc_URLClassPath$FileLoader {
 
     @Alias
@@ -25,7 +26,7 @@ final class Target_sun_misc_URLClassPath$FileLoader {
     }
 }
 
-@TargetClass(className = "sun.misc.URLClassPath")
+@TargetClass(className = "sun.misc.URLClassPath", onlyWith = JDK8OrEarlier.class)
 final class Target_sun_misc_URLClassPath {
 
     @Substitute

The onlyWith = JDK8OrEarlier.class is necessary for classes that Quarkus has substitutions for but have been removed on JDK11.

The LocalizationSupport -> LocalizationFeature change will be necessary due to some changes in GraalVM internals wich Quarkus depends on. You should try to avoid depending on non-API internals. Currently the supported way to register resource bundles is either via resource configuration file or the -H:IncludeResourceBundles option. If you need a programatic API we could provide that.

[cstancu]

@gsmet the onlyWith = JDK8OrEarlier.class changes that I mentioned above could be integrated before the 19.3.0 release and I think it should be enough to allow us to enable the Quarkus integration tests for JDK11.