WebSockets Next: OTel integration

[mkouba]

Description

Follow-up of #39142.

Implementation ideas

No response

[michalvavrik]

hey @brunobat, is this WIP or can I have a look later this / next week? Feel free to share high-level plan if you have one or we could discuss this via DM.

[mkouba]

hey @brunobat, is this WIP or can I have a look later this / next week? Feel free to share high-level plan if you have one or we could discuss this via DM.

The plan is to wait a bit until it's 100% clear what API should we actually use. See also Bruno's Micrometer, Observation API and OpenTelemetry roadmap email.

[michalvavrik]

The plan is to wait a bit until it's 100% clear what API should we actually use. See also Bruno's Micrometer, Observation API and OpenTelemetry roadmap email.

The email says nothing about WS and neither says description of this issue about waiting. I'm not sure why should integration differ to any other integration with Quarkus REST, gRPC etc. but I'll leave it to experts and let @brunobat handle this issue. Thank you for info

[michalvavrik]

hey @brunobat in case you want to help with this one when the time is right, ping me

[brunobat]

Created a meeting for next monday with @mkouba and @michalvavrik. If anyone else want to be there, please let me know.

[brunobat]

About tracing:
We will be creating spans for:

• Open connection. It can be linked to the request opening the connection.
• Close connection with the open connection as a link because this is not related with the request that originated the open.

---

About Metrics:

• Count open connections
• Count per target (channel):
  • Server messages count received
  • Server messages count received errors
  • Server messages count bytes sent
  • Server messages count bytes received
  • Client messages count sent
  • Client messages count sent errors
  • Client messages count bytes sent
  • Client messages count bytes received

---

In relation to the architecture of the solution we should proceed in a similar way we did for reactive messaging.

[geoand]

@brunobat can you explain the tracing part a little more as I don't really understand it?

Thanks

[brunobat]

Sure @geoand. The idea for tracing is that creating spans for individual messages does not make much sense because:

• They can be really small and each span could be 10x larger...
• Keep track of the parent for each sent message can be hard
• The connection is opened in a request and might be kept open for a very long time... Better use a link to correlate with close.