Deleted servlet are still served with shamrock:dev

[cescoffier]

Reproducer:

1. Create a project
2. Run mvn compile shamrock:dev
3. Create a servlet
4. Check it's served
5. Delete the servlet
6. Servlet is still served, while it should not.

[stuartwdouglas]

This is complicated by the fact that there is not a 1:1 relationship between class and source files. If we do this we will need to use ASM to read the SourceFile attribute of any classes that don't have a matching .java file, to make sure we don't remove classes that are still present in the source.

[cescoffier]

That sounds reasonable. Let me adjust the tests.

Do you think we need a "known limitations" somewhere in the doc?

[cescoffier]

Does it mean that for the same reason the updates are not reflected either?

[cescoffier]

sorry, my bad... my test was wrong. NotEnoughCoffeeException

[cescoffier]

But, we do have the same behavior when we delete a jax-rs resource. Can you confirm?

[cescoffier]

@stuartwdouglas confirmed the behavior.

Closing the issue.

[Sanne]

There's still a test diabled with comments:

@Test
-    @Disabled("Issue https://github.com/jbossas/protean-shamrock/issues/245")
-    public void testThatTheApplicationIsReloadedOnNewServlet() throws MavenInvocationException, IOException {

What about that? Should it be re-enabled, removed?

[cescoffier]

I guess we want to remove the test completely.