quarkus-maven-plugin DevMojo erroneously excludes local project dependencies

[jimbogithub]

Describe the bug
Unexpected warning message is displayed for local project dependencies that are not extension dependencies during quarkus:dev:

[WARNING] Local Quarkus extension dependency <group-id>:<project-id> will not be hot-reloadable

By adding logging to the quarkus-maven-plugin DevMojo, it is apparent that the
DevMojo is excluding transitive dependencies of test dependencies even if those transitive dependencies are also normal dependencies (direct or transitive) of the local project. This was introduced by commit f043971.

Expected behavior
No warning, local dependencies are hot-reloadable.

Actual behavior
Warning displayed, local dependencies are not hot-reloadable.

Additional context
See https://groups.google.com/d/msg/quarkus-dev/Q-dbG9v_T4U/tICQwiDoCAAJ

[quarkusbot]

/cc @quarkusio/devtools

[famod]

So for your setup this is regression in 1.6.0.CR1? cc @aloubyansky

[jimbogithub]

It was OK in 1.4.2.Final.
It is a problem in 1.5.x and 1.6.0.CR1.

[jimbogithub]

The issue discussed here only applies to the hot deployability of the dependencies.

However I do see an extra new issue with 1.6.0.CR1 which only occurs on projects that suffer from the problem described in this issue. In this example com.redacted.BaseEntity is in one of the non-hot-deployable dependencies:

	at io.quarkus.hibernate.orm.runtime.boot.FastBootEntityManagerFactoryBuilder.persistenceException(FastBootEntityManagerFactoryBuilder.java:115)
	at io.quarkus.hibernate.orm.runtime.boot.FastBootEntityManagerFactoryBuilder.build(FastBootEntityManagerFactoryBuilder.java:75)
	at io.quarkus.hibernate.orm.runtime.FastBootHibernatePersistenceProvider.createEntityManagerFactory(FastBootHibernatePersistenceProvider.java:54)
	at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:80)
	at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:55)
	at io.quarkus.hibernate.orm.runtime.JPAConfig$LazyPersistenceUnit.get(JPAConfig.java:163)
	at io.quarkus.hibernate.orm.runtime.JPAConfig.startAll(JPAConfig.java:84)
	at io.quarkus.hibernate.orm.runtime.HibernateOrmRecorder.startAllPersistenceUnits(HibernateOrmRecorder.java:95)
	at io.quarkus.deployment.steps.HibernateOrmProcessor$startPersistenceUnits-1681903524.deploy_0(HibernateOrmProcessor$startPersistenceUnits-1681903524.zig:70)
	at io.quarkus.deployment.steps.HibernateOrmProcessor$startPersistenceUnits-1681903524.deploy(HibernateOrmProcessor$startPersistenceUnits-1681903524.zig:36)
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:588)
	at io.quarkus.runtime.Application.start(Application.java:90)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:91)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:61)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:38)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:106)
	at io.quarkus.runner.GeneratedMain.main(GeneratedMain.zig:29)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl$3.run(StartupActionImpl.java:136)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.hibernate.MappingException: Could not instantiate persister org.hibernate.persister.entity.SingleTableEntityPersister
	at org.hibernate.persister.internal.PersisterFactoryImpl.createEntityPersister(PersisterFactoryImpl.java:112)
	at org.hibernate.persister.internal.PersisterFactoryImpl.createEntityPersister(PersisterFactoryImpl.java:77)
	at org.hibernate.metamodel.internal.MetamodelImpl.initialize(MetamodelImpl.java:181)
	at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:301)
	at io.quarkus.hibernate.orm.runtime.boot.FastBootEntityManagerFactoryBuilder.build(FastBootEntityManagerFactoryBuilder.java:73)
	... 21 more
Caused by: java.lang.IllegalAccessError: failed to access class com.redacted.BaseEntity$1 from class com.redacted.BaseEntity (com.redacted.BaseEntity$1 is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @3c41ed1d; com.redacted.BaseEntity is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @2715644a)
	at com.redacted.BaseEntity.<clinit>(BaseEntity.java:37)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.hibernate.engine.internal.UnsavedValueFactory.instantiate(UnsavedValueFactory.java:40)
	at org.hibernate.engine.internal.UnsavedValueFactory.getUnsavedIdentifierValue(UnsavedValueFactory.java:68)
	at org.hibernate.tuple.PropertyFactory.buildIdentifierAttribute(PropertyFactory.java:62)
	at org.hibernate.tuple.entity.EntityMetamodel.<init>(EntityMetamodel.java:136)
	at org.hibernate.persister.entity.AbstractEntityPersister.<init>(AbstractEntityPersister.java:604)
	at org.hibernate.persister.entity.SingleTableEntityPersister.<init>(SingleTableEntityPersister.java:125)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.hibernate.persister.internal.PersisterFactoryImpl.createEntityPersister(PersisterFactoryImpl.java:96)
	... 25 more

[jimbogithub]

I suspect the new issue in 1.6.0.CR1 might be related to #10371 as we both appear to have ORM base classes in external modules.

[aloubyansky]

By adding logging to the quarkus-maven-plugin DevMojo, it is apparent that the
DevMojo is excluding transitive dependencies of test dependencies even if those transitive dependencies are also normal dependencies (direct or transitive) of the local project. This was introduced by commit f043971.

I confirm I can reproduce it. Fixing it now.

[jimbogithub]

@aloubyansky Not sure if it's useful info, but I tested for the second 1.6.0.CR1 specific ClassLoader issue that I thought might be related to #10371 and found that it goes away if I remove the test dependencies. So it shows it is/was also related to this issue in my case. Will check both with your fix when available.