Merge the native and kubernetes quickstart in getting started #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and generated project It fixes #69 and is related to quarkusio/quarkus#1365
…in in the "getting-started" quickstart project In relation to quarkusio/quarkus#1365
This was referenced Mar 10, 2019
|
/LGTM |
gsmet
requested changes
Mar 11, 2019
There was a problem hiding this comment.
@cescoffier could you remove the microprofile-config.properties? Other than that, it looks good.
Your PR is against master. Is it what you wanted to do?
| @@ -0,0 +1,2 @@ | |||
| # Configuration file | |||
| key = value | |||
|
Yes, this PR is against |
gsmet
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the project generated by the user contains everything required, no need for 3 quickstarts anymore.
Also, this PR make the instructions more consistent.