Load FileSystemProviders with system cl #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postremus
force-pushed
the
provider-with-syscl
branch
from
1fbd0d6 to
6a13ba8
Compare
gsmet
reviewed
Dec 15, 2021
| break; | ||
| final ClassLoader ccl = Thread.currentThread().getContextClassLoader(); | ||
| try { | ||
| // We are loading "installed" FS providers that are loaded from from the system classloader anyway |
There was a problem hiding this comment.
Suggested change
| // We are loading "installed" FS providers that are loaded from from the system classloader anyway | |
| // We are loading "installed" FS providers that are loaded from the system classloader anyway |
Postremus
force-pushed
the
provider-with-syscl
branch
from
6a13ba8 to
19ccf6d
Compare
|
Green Quarkus CI Run: https://github.com/Postremus/quarkus/actions/runs/1584777716 |
gsmet
approved these changes
Dec 18, 2021
|
I released 0.0.4, you'll need to wait until it's synced to Maven Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FSP are discovered using the system classloader. if a custom provider tries to load classes using
Thread.currentThread().getContextClassLoader().loadClassa ClassCastException is thrown.Same idea as was originally done in quarkusio/quarkus#9774.
Moving the fix over to this lib, since I want to get rid of it in ClassPathUtils for future optimizations.