Add test coverage for QUARKUS-5858

[mocenas]

Summary

Implement tests based on quarkus-qe/quarkus-test-plans#232.

Please select the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• Dependency update
• Refactoring
• Backport
• New scenario (non-breaking change which adds functionality)
• This change requires a documentation update
• This change requires execution against OCP (use run tests phrase in comment)
• This change requires execution with OCP on Aarch64 (use run arm tests phrase in comment)

Checklist:

• Methods and classes used in PR scenarios are meaningful
• Commits are well encapsulated and follow the best practices

[michalvavrik]

Well done.

[michalvavrik]

In OpenShift, we need to use image = "${rhbk.image}" because IBM Z/PE fail with upstream image (architecture not supported). We could also disable it for them, but seems unnecesary.

[mocenas]

I've added this for OCP tests

[michalvavrik]

Let's also make sure that GH CI and OCP are passing (because failures are due to the added test here), but test code lgtm.

[mocenas]

Test failures are caused by quarkusio/quarkus#48085. Which is already fixed upstream - quarkusio/quarkus#48091

We will probably need to wait for next Quarkus 999-snapshot to have the fix available.

[michalvavrik]

We will probably need to wait for next Quarkus 999-snapshot to have the fix available.

We implemented remote trigger in TS PR using GH PR commetns, just write "hey @rsvoboda , please trigger https://github.com/quarkusio/quarkus/actions/workflows/deploy-snapshots.yml" and we will be able to rerun this PR CI later today.

[mocenas]

I found another issue quarkusio/quarkus#48110 when dealing with original issue fix. I'm not sure how this one is going to be resolved, possibly it will require some code changes in this PR. I'm changing this to draft before the issue gets resolved.

[michalvavrik]

just note - both of these issues will be a problem for 3.20.1 backport, they will probably have to be documented as known issues and test methods enabled (or the ticket fix version needs to be adjusted to 3.20.NEXT).

[mocenas]

I've made the changes for last issue and some requested. Should be ready for review now.

[mocenas]

run tests

[mocenas]

That's weird. There are still test failures. Caused by the problem that was fixed in quarkusio/quarkus#48091. That PR was merged several days ago, but fix is still not in current 999-SNAPSHOT.

[michalvavrik]

That's weird. There are still test failures. Caused by the problem that was fixed in quarkusio/quarkus#48091. That PR was merged several days ago, but fix is still not in current 999-SNAPSHOT.

I know how to fix it, it's in our CI, looking right now.

[mocenas]

run tests

[mocenas]

run tests

[mocenas]

Tests still fails on OCP as fix is not propagated there. Do you known any other "magic trick" why this is happening @michalvavrik ?

[michalvavrik]

Tests still fails on OCP as fix is not propagated there. Do you known any other "magic trick" why this is happening @michalvavrik ?

I do, I didn't get to it yesterday. Can you just replace https://s01.oss.sonatype.org/content/repositories/snapshots/ occurrence in Jenkins jobs with https://central.sonatype.com/repository/maven-snapshots/? Bit busy ATM.

[michalvavrik]

should be fixed now

[michalvavrik]

run tests

[mocenas]

run tests

[mocenas]

Unfortunately didn't help :-(

[michalvavrik]

Unfortunately didn't help :-(

I think there is some caching in place, let me check.

[michalvavrik]

run tests

[michalvavrik]

CI green, merging