Skip to content

Adding Micrometer tests for WebSockets.next #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Adding Micrometer tests for WebSockets.next #2404

merged 1 commit into from
Apr 17, 2025

Conversation

@mjurc
Copy link
Member

@mjurc mjurc commented Apr 16, 2025

Summary

  • Adding tests for Micrometer metrics exposed for WebSockets.

Test plan: https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-5667.md

Feature issue: https://issues.redhat.com/browse/QUARKUS-5667

Code changes: quarkusio/quarkus#44379

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)
  • This change requires execution with OCP on Aarch64 (use run arm tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc mjurc requested a review from jedla97 April 16, 2025 21:32
@mjurc mjurc force-pushed the QUARKUS-5667 branch 2 times, most recently from 99de3dd to eeed13d Compare April 16, 2025 22:10
@mjurc mjurc self-assigned this Apr 16, 2025
@mjurc mjurc added the triage/backport-3.20 Changes relevant for Quarkus 3.20 label Apr 16, 2025
@mjurc
Copy link
Member Author

mjurc commented Apr 16, 2025

run arm tests

jedla97
jedla97 reviewed Apr 17, 2025
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just have some comments

jedla97
jedla97 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update!

@mjurc
Copy link
Member Author

mjurc commented Apr 17, 2025

And one more to fix import ordering

@michalvavrik michalvavrik merged commit a45377f into quarkus-qe:main Apr 17, 2025
7 checks passed
@mjurc mjurc mentioned this pull request Apr 17, 2025
Merged
10 tasks
@jedla97 jedla97 removed the triage/backport-3.20 Changes relevant for Quarkus 3.20 label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees

@mjurc mjurc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjurc @jedla97 @michalvavrik