-
Notifications
You must be signed in to change notification settings - Fork 3
Allow for customization of the BrowserContext
#112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This would also open up a pattern to be able to further customize the `BrowserContext`, or other things within Playwright. I initially tried to do it via properties (i.e. `quarkus.playwright.*`, but unfortunately a `QuarkusTestResourceConfigurableLifecycleManager` doesn't have access to `@ConfigMapping`s (I checked with Georgios).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@melloware this doesn't actually fix #60. It has something in common, but doesn't solve that problem. See #60 (comment) |
OK I removed the tag. I love this PR though when you get it working. |
This PR is working and complete. I only provided a couple of options for now. I didn't want to have to mirror the entire Playwright API. A Even trying to unwrap it with If we want to move to a properties-based configuration model then we will have to move away from having the implementation using a |
want me to publish a release? |
@all-contributors add @edeandrea for code |
I've put up a pull request to add @edeandrea! 🎉 |
That's up to you. Would be nice to have this feature! I was implementing it myself with JUnit on the BrowserContext and figured having it on the framework would be a better place. |
publishing 2.1.0 now! |
2.1.0 is in Maven Central |
This would also open up a pattern to be able to further customize the
BrowserContext
, or other things within Playwright.I initially tried to do it via properties (i.e.
quarkus.playwright.*
), but unfortunately aQuarkusTestResourceConfigurableLifecycleManager
doesn't have access to@ConfigMapping
s (I checked with Georgios).