Skip to content

OpenAPI Filter force its order to prevent flickering #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

OpenAPI Filter force its order to prevent flickering #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-openapi-spi</artifactId>
<artifactId>quarkus-smallrye-openapi-deployment</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deployment? @OpenApiFilter is in the runtime library.

Suggested change
<artifactId>quarkus-smallrye-openapi-deployment</artifactId>
<artifactId>quarkus-smallrye-openapi</artifactId>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment modules usually depend on other extension's deployment modules

</dependency>

<dependency>
Expand Down Expand Up @@ -86,4 +86,4 @@
</plugins>
</build>

</project>
</project>
4 changes: 3 additions & 1 deletion ...t/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerOpenAPIFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
import org.eclipse.microprofile.openapi.models.tags.Tag;

import io.quarkiverse.loggingmanager.LogController;
import io.quarkus.smallrye.openapi.OpenApiFilter;

/**
* Create OpenAPI entries (if configured)
*/
@OpenApiFilter(value = OpenApiFilter.RunStage.BOTH, priority = 99)
public class LoggingManagerOpenAPIFilter implements OASFilter {

private static final String JSON_CONTENT_TYPE = "application/json";
Expand Down Expand Up @@ -140,4 +142,4 @@ private PathItem createLevelsPathItem() {
.items(OASFactory.createSchema().ref(REF_LOGGER_LEVEL))))))));
}

}
}
6 changes: 5 additions & 1 deletion runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-vertx-http</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-openapi</artifactId>
</dependency>
</dependencies>

<build>
Expand Down Expand Up @@ -57,4 +61,4 @@
</plugin>
</plugins>
</build>
</project>
</project>