Skip to content

Conversation

nasonawa
Copy link
Contributor

@nasonawa nasonawa commented Jul 29, 2025

Fixed the MCP Streamable Parsing Incomplete response, using record parser.

@nasonawa nasonawa requested a review from a team as a code owner July 29, 2025 09:24
this.mcpSessionId.set(mcpSessionId);
}

RecordParser sseEventparser = RecordParser.newDelimited("\n\n", bodyBuffer -> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if \n\n is always the delimiter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has been minimized.

@geoand
Copy link
Collaborator

geoand commented Jul 29, 2025

Thanks for this!

I would really like to see a test for this because I have a hunch that we will be hit by the same problem that quarkusio/quarkus#48852 solved for the REST Client

This comment has been minimized.

@geoand
Copy link
Collaborator

geoand commented Jul 31, 2025

Can you please fix the formatting issue and rebase onto main? I can also do that for you if you wish

@nasonawa nasonawa force-pushed the mcp_streamhttp_recordparse_sse_events branch from 7d646f8 to cc0e260 Compare August 1, 2025 11:52

This comment has been minimized.

@geoand
Copy link
Collaborator

geoand commented Aug 1, 2025

Please squash the commits and then we can get this in

@nasonawa nasonawa force-pushed the mcp_streamhttp_recordparse_sse_events branch from cc0e260 to f9e5a90 Compare August 1, 2025 12:38
Copy link

quarkus-bot bot commented Aug 1, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit f9e5a90.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 35e1c5f into quarkiverse:main Aug 1, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP Streamable Parsing Incomplete response causing the JsonEOFException

2 participants