-
Notifications
You must be signed in to change notification settings - Fork 156
added Record Parser to parse each sse event #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Record Parser to parse each sse event #1657
Conversation
this.mcpSessionId.set(mcpSessionId); | ||
} | ||
|
||
RecordParser sseEventparser = RecordParser.newDelimited("\n\n", bodyBuffer -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if \n\n
is always the delimiter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the "\n\n" is the delimiter for the events, here are the related resources.
[1] https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events#event_stream_format
[2] https://web.dev/articles/eventsource-basics#event_stream_format
This comment has been minimized.
This comment has been minimized.
Thanks for this! I would really like to see a test for this because I have a hunch that we will be hit by the same problem that quarkusio/quarkus#48852 solved for the REST Client |
This comment has been minimized.
This comment has been minimized.
Can you please fix the formatting issue and rebase onto |
7d646f8
to
cc0e260
Compare
This comment has been minimized.
This comment has been minimized.
Please squash the commits and then we can get this in |
cc0e260
to
f9e5a90
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed the MCP Streamable Parsing Incomplete response, using record parser.