feat: add support for including RDS instance tags as labels in all metrics #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true Signed-off-by: Andreas Poletti <[email protected]>
andreaspoletti
force-pushed
the
add-tags-in-metrics
branch
from
e5779c5 to
6b7cb98
Compare
Signed-off-by: Andreas Poletti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, RDS instance tags were only available in the dedicated metric. This made it difficult to filter or group other RDS metrics by team, service, environment, or other tag-based identifiers in Prometheus and Grafana, without logic on the datasource part or in the dashboards. Our goal is to filter everything directly from Victoria Metrics without implementing additional logic into any part of the monitoring process, and by using filtering via
extra_label.This is described in #255.
Solution
This PR adds a new
include-tags-in-metricsflag that allows RDS instance tags to be included as labels in all exported metrics when enabled.