Bugfix: Add curl to goreleaser docker image - fix "curl: not found" in healthcheck function issue #249 #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shirak Elbakyan <[email protected]>
elshirak
force-pushed
the
issue249--fix-healthcheck-alpine-container
branch
from
62e1fb9 to
e744961
Compare
elshirak
changed the title
|
LGTM. We are doing it this in local development environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
I've prepared a PR that addresses the issue described in issue #249
I believe this is a good solution since it's implemented similarly to how curl was added here.
I'm happy to hear any feedback, and I can also easily rewrite the healthcheck to use the standard Alpine
wgetif needed.What do you think on this @qfritz @vmercierfr ?