-
Notifications
You must be signed in to change notification settings - Fork 124
Optimize Dockerfile #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MH0386
wants to merge
10
commits into
qdrant:master
Choose a base branch
from
MH0386:optimize-dockerfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes the Dockerfile by upgrading the Python base image, modernizing package management with uv, and improving server network accessibility in containerized environments.
- Upgrades Python base image from 3.11-slim to 3.13-slim
- Switches from pip-based uv installation to pre-built binary from ghcr.io
- Adds FASTMCP_HOST environment variable to enable network interface binding
Comments suppressed due to low confidence (1)
Dockerfile:6
- The uv version 0.8.3 may not exist. As of my knowledge cutoff in January 2025, the latest stable versions were in the 0.4.x range. Please verify that version 0.8.3 is available at ghcr.io/astral-sh/uv before using it.
COPY --from=ghcr.io/astral-sh/uv:0.8.3 /uv /uvx /bin/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Dockerfile
to use a newer Python base image, improve package management, and enhance configurability for the server. Key changes include upgrading the Python version, switching to a more efficient package installation method, and adding a new environment variable to allow the server to listen on all network interfaces.Base image and package management updates:
python:3.11-slim
topython:3.13-slim
for compatibility with the latest Python features and improvements.pip
-based installation of theuv
package with a pre-built binary fromghcr.io
, improving efficiency and reducing build complexity.mcp-server-qdrant
package using theuv tool install
command instead ofuv pip install
, aligning with the new package management approach.Server configuration improvements:
FASTMCP_HOST
environment variable to make the server listen on all network interfaces (0.0.0.0
), improving accessibility in containerized environments.CMD
instruction to use a JSON array format for better compatibility with Docker's execution model.