Merge Qube Template to Development #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| void start(BundleContext context ) throws Exception { | ||
|
|
||
| System.out.println( context.getBundle().getSymbolicName() + ": Hello OSGi-World." ) |
There was a problem hiding this comment.
are these and the car example classes needed?
There was a problem hiding this comment.
They're introduced by the QUBE Template, I'm unsure how to proceed here since we would have to delete them every time we merge TEMPLATE back into development, (when changes are made to the scaffolding code)
wow-such-code
requested changes
Dec 4, 2020
Co-authored-by: wow-such-code <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR intends to update
xml-manager-libto the current Qube Template:pom.xmland move its dependencies and versions to the xml-manager-libpom.xmljaxb-coredependency with org.glassfish.jaxbjaxb-runtimedependency to account for the move from JDK 8 to JDK 11