Skip to content

Conversation

juefeng
Copy link
Contributor

@juefeng juefeng commented Jul 28, 2025

workbook.xml.rels文件中Relationship的Target应该xl目录下的相对路径,sheet的Traget应该是worksheets/sheet%d.xml

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

workbook.xml.rels文件中Relationship的Target应该xl目录下的相对路径,sheet的Traget应该是worksheets/sheet%d.xml
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. LGTM.

@xuri xuri changed the title sheet的Traget应该是worksheets/sheet%d.xml Using absolute sheet target path in the internal workbook relationship parts Jul 28, 2025
@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2025
@xuri xuri changed the title Using absolute sheet target path in the internal workbook relationship parts Using relative sheet target path in the internal workbook relationship parts Jul 28, 2025
@xuri xuri moved this to Improve the Compatibility in Excelize v2.10.0 Jul 28, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (4a354cb) to head (1952ca3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2185   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          32       32           
  Lines       30488    30488           
=======================================
  Hits        30257    30257           
  Misses        153      153           
  Partials       78       78           
Flag Coverage Δ
unittests 99.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri merged commit b674220 into qax-os:master Jul 29, 2025
17 checks passed
crush-wu pushed a commit to crush-wu/excelize that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Improve the Compatibility
Development

Successfully merging this pull request may close these issues.

2 participants