Skip to content

DefinedNames SheetNames are not escaped correctly, if a sheet gets renamed #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025
Merged

DefinedNames SheetNames are not escaped correctly, if a sheet gets renamed #2127

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f307957
[BUGFIX]: adjustRangeSheetName does not escape sheet names in named r…
R3dByt3 May 7, 2025
f87d0b2
[MISC]: Updated tests
R3dByt3 May 7, 2025
04026de
Merge branch 'qax-os:master' into master
R3dByt3 May 7, 2025
3cc657e
[REFACTORING]: Using escapeSheetName(target) instead of regex
R3dByt3 May 8, 2025
77d385c
[REFACTORING]: Using escapeSheetName(target) instead of regex
R3dByt3 May 8, 2025
5c56518
[REFACTORING]: Using escapeSheetName(target) instead of regex
R3dByt3 May 8, 2025
4bc377a
[REFACTORING]: Using escapeSheetName(target) instead of regex
R3dByt3 May 8, 2025
94e115d
[REFACTORING]: Using escapeSheetName(target) instead of regex
R3dByt3 May 8, 2025
43c6572
[MISC]: Added test
R3dByt3 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions adjust.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,9 +468,7 @@ func adjustRangeSheetName(rng, source, target string) string {
part = strings.TrimPrefix(strings.TrimSuffix(part, "'"), "'")
}
if part == source {
if part = target; singleQuote {
part = "'" + part + "'"
}
part = escapeSheetName(target)
}
parts[k] = part
}
Expand Down
4 changes: 2 additions & 2 deletions sheet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,8 @@ func TestSetSheetName(t *testing.T) {
Name: "Name3",
RefersTo: "Sheet1!$A$1:'Sheet1'!A1:Sheet1!$A$1,Sheet1!A1:Sheet3!A1,Sheet3!A1",
}))
assert.NoError(t, f.SetSheetName("Sheet1", "Sheet2"))
for i, expected := range []string{"'Sheet2'!$A$1:$A$2", "$B$2", "$A1$2:A2", "Sheet2!$A$1:'Sheet2'!A1:Sheet2!$A$1,Sheet2!A1:Sheet3!A1,Sheet3!A1"} {
assert.NoError(t, f.SetSheetName("Sheet1", "Sheet 2"))
for i, expected := range []string{"'Sheet 2'!$A$1:$A$2", "$B$2", "$A1$2:A2", "'Sheet 2'!$A$1:'Sheet 2'!A1:'Sheet 2'!$A$1,'Sheet 2'!A1:Sheet3!A1,Sheet3!A1"} {
assert.Equal(t, expected, f.WorkBook.DefinedNames.DefinedName[i].Data)
}
}
Expand Down