Skip to content

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented Aug 18, 2025

No description provided.

@qarmin qarmin requested a review from Copilot August 18, 2025 06:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be testing CI changes while also adding debug logging to improve observability of file operations. The primary purpose seems to be fixing CI configuration issues related to codegen-units settings across different platforms.

  • Fixed CI configuration by correcting sed patterns for codegen-units in GitHub Actions workflows
  • Added debug logging with timing measurements for file operations (delete, move, rename)
  • Enhanced model processor with debug output showing processing statistics

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
krokiet/src/model_operations/model_processor.rs Added debug logging import, message type helper method, and timing measurements for processing operations
czkawka_gui/src/connect_things/connect_button_move.rs Added debug logging with timing for file move operations
czkawka_gui/src/connect_things/connect_button_delete.rs Added debug logging with timing and counters for file/folder deletion operations
.github/workflows/windows.yml Fixed sed pattern for codegen-units configuration
.github/workflows/mac.yml Fixed sed pattern for codegen-units configuration
.github/workflows/linux.yml Fixed sed pattern for codegen-units configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

set -e
sed -i '' 's/#lto = "thin"/lto = "thin"/g' Cargo.toml
sed -i '' 's/#codegen-units = 1/codegen-units = 1/g' Cargo.toml
sed -i '' 's/#codegen-units /codegen-units /g' Cargo.toml
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed pattern is incomplete and will result in invalid TOML syntax. It removes the comment character but doesn't set a value for codegen-units. Consider using 's/#codegen-units = 1/codegen-units = 1/g'.

Suggested change
sed -i '' 's/#codegen-units /codegen-units /g' Cargo.toml
sed -i '' 's/#codegen-units = 1/codegen-units = 1/g' Cargo.toml

Copilot uses AI. Check for mistakes.

@qarmin qarmin merged commit 6407d2c into master Aug 18, 2025
26 checks passed
@qarmin qarmin deleted the ci_again branch August 18, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant