Skip to content

Conversation

@qarmin
Copy link
Owner

@qarmin qarmin commented Aug 12, 2025

  • fat lto instead thin lto - ~25% size reduced - mostly gained by krokiet
  • improved charts/collecting info about compilation times/sizes
  • info about number of deleted items
  • workaround for bug, when changing items both from slint and rust broke krokiet bindings

@qarmin qarmin requested a review from Copilot August 12, 2025 19:56

This comment was marked as outdated.

@qarmin qarmin requested a review from Copilot August 15, 2025 19:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements a feature to show the number of items to be deleted in Krokiet before deletion. The PR adds functionality to display a detailed confirmation message showing the exact count of selected items and, for grouped views, the number of groups with selected items and groups with all items selected.

Key changes include:

  • Added logic to count and display detailed item selection information before deletion
  • Renamed CurrentTab enum to ActiveTab for better naming consistency
  • Updated compilation configuration for smaller binaries using fat LTO instead of thin LTO

Reviewed Changes

Copilot reviewed 42 out of 44 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
krokiet/src/model_operations/mod.rs Added functions to count checked items and analyze group selection patterns
krokiet/src/connect_delete.rs Implemented delete confirmation dialog with detailed item counts
krokiet/i18n/en/krokiet.ftl Added new translation keys for delete confirmation messages
krokiet/src/connect_translation.rs Updated translation reference from generic to specific delete confirmation key
misc/test_compilation_speed_size/ Added new compilation testing infrastructure with JSON configuration
krokiet/ui/ Renamed CurrentTab to ActiveTab throughout UI files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qarmin qarmin merged commit 3f7f86a into master Aug 15, 2025
26 checks passed
@qarmin qarmin deleted the ext222 branch August 15, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants