- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 852
 
Showing the number of items to be deleted in Krokiet, before deletion. #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements a feature to show the number of items to be deleted in Krokiet before deletion. The PR adds functionality to display a detailed confirmation message showing the exact count of selected items and, for grouped views, the number of groups with selected items and groups with all items selected.
Key changes include:
- Added logic to count and display detailed item selection information before deletion
 - Renamed 
CurrentTabenum toActiveTabfor better naming consistency - Updated compilation configuration for smaller binaries using fat LTO instead of thin LTO
 
Reviewed Changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description | 
|---|---|
| krokiet/src/model_operations/mod.rs | Added functions to count checked items and analyze group selection patterns | 
| krokiet/src/connect_delete.rs | Implemented delete confirmation dialog with detailed item counts | 
| krokiet/i18n/en/krokiet.ftl | Added new translation keys for delete confirmation messages | 
| krokiet/src/connect_translation.rs | Updated translation reference from generic to specific delete confirmation key | 
| misc/test_compilation_speed_size/ | Added new compilation testing infrastructure with JSON configuration | 
| krokiet/ui/ | Renamed CurrentTab to ActiveTab throughout UI files | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.